Closed rndquu closed 1 month ago
Out at the moment but was tasked with this earlier on TG.
I have a hot fix PR opened at work.ubq.fi to solve the UI problem immediately
I'd be grateful if you could assign or I will once back
Out at the moment but was tasked with this earlier on TG.
I have a hot fix PR opened at work.ubq.fi to solve the UI problem immediately
I'd be grateful if you could assign or I will once back
There's already a similar issue https://github.com/ubiquity/devpool-directory-bounties/issues/30
@jordan-ae was the 1st one to pick it up so if he's still working on it then let's give him some time to self assign
@rndquu since we opened a new pr here we can close #30 as not planned. I'm working on it almost done. I could submit a PR right away but I don't know how to test this repo locally that's whats been holding me back
@rndquu since we opened a new pr here we can close #30 as not planned. I'm working on it almost done. I could submit a PR right away but I don't know how to test this repo locally that's whats been holding me back
This issue is pretty critical because it affects work.ubq.fi
so either make sure your PR runs locally against your own devpool-directory
repository without any errors either let @Keyrxng self assign it
but I don't know how to test this repo locally
You make your own directory and test against it
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 150 |
Issue | Comment | 1 | 0 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@rndquu since we opened a new pr here we can close #30 as not pl… | 0content: p: count: 44 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.2 | - |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 1.17 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Out at the moment but was tasked with this earlier on TG. I hav… | 3.9content: p: count: 39 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.3 | 1.17 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 41.1 |
Issue | Comment | 2 | 3.28 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Original [comment](https://github.com/ubiquity/devpool-directory… | 41.1content: p: count: 40 score: 1 a: count: 3 score: 1 code: count: 9 score: 1 ul: count: 55 score: 0 li: count: 85 score: 1 ol: count: 30 score: 0 wordValue: 0.1 formattingMultiplier: 3 | 1 | 41.1 |
There's already a similar issue https://github.com/ubiquity/devp… | 6.2content: p: count: 31 score: 1 wordValue: 0.2 formattingMultiplier: 1 | 0.2 | 1.24 |
This issue is pretty critical because it affects `work.ubq.f… | 6.8content: p: count: 31 score: 1 code: count: 2 score: 1 a: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 1 | 0.3 | 2.04 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.09 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
You make your own directory and test against it | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.1 | 0.09 |
@gentlementlegen it didnt collect any review comments this time.
I think this needs re-opened as the run isn't deleting issues (run)
To delete an issue the authToken
used must have admin permissions which I'm sure the bot does not have
Hmm should we make a dedicated GitHub app for this purpose? It seems safer?
The app auth itself wouldn't be valid but if it's possible to give it admin permissions and then use it's token I don't see why that wouldn't work.
We might be able to do it by creating a fine-grained PAT with the resource owner being either the org or failing that then a user who has admin permissions. Scope it only to the devpool-directory
repo with access to issues
and admin
on repo settings and idk if needed but admin
on org too.
I think it looks more professional to use a bot instead of a personal account. And I'm pretty sure PAT is only for personal accounts.
I can make the app when I'm back on my computer tomorrow. I'll write a reminder.
And I'm pretty sure PAT is only for personal accounts.
I expect that @jordan-ae will be required to resolve this considering a payout was made yeah?
I think it looks more professional to use a bot instead of a personal account.
So what needs done is:
admin
role/permissions within the orgauthToken
from that app to delete the issuesI'll write a reminder.
/remindMe 1 day
;)))View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 150 |
Issue | Comment | 4 | 0 |
Review | Comment | 1 | 0 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Out at the moment but was tasked with this earlier on TG. I hav… | 0content: p: count: 39 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.3 | - |
I think this needs re-opened as the run isn't deleting issues ([… | 0content: p: count: 31 score: 1 a: count: 3 score: 1 ul: count: 23 score: 0 li: count: 23 score: 1 hr: count: 1 score: 0 code: count: 1 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.7 | - |
- https://docs.github.com/en/rest/authentication/permissions-req… | 0content: ul: count: 84 score: 0 li: count: 84 score: 1 code: count: 4 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.6 | - |
![image](https://github.com/user-attachments/assets/f2821b01-7ba… | 0content: h2: count: 1 score: 1 img: count: 1 score: 0 p: count: 21 score: 1 ul: count: 51 score: 0 li: count: 51 score: 1 code: count: 5 score: 1 h6: count: 4 score: 1 wordValue: 0 formattingMultiplier: 0 | 0.8 | - |
Resolves https://github.com/ubiquity/devpool-directory-bounties/… | 0content: p: count: 66 score: 1 ul: count: 129 score: 0 li: count: 161 score: 1 code: count: 12 score: 1 hr: count: 1 score: 0 ol: count: 32 score: 0 wordValue: 0 formattingMultiplier: 0 | 0.9 | - |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 41.1 |
Issue | Comment | 2 | 7.86 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Original [comment](https://github.com/ubiquity/devpool-directory… | 41.1content: p: count: 40 score: 1 a: count: 3 score: 1 code: count: 9 score: 1 ul: count: 55 score: 0 li: count: 85 score: 1 ol: count: 30 score: 0 wordValue: 0.1 formattingMultiplier: 3 | 1 | 41.1 |
There's already a similar issue https://github.com/ubiquity/devp… | 6.2content: p: count: 31 score: 1 wordValue: 0.2 formattingMultiplier: 1 | 0.5 | 3.1 |
This issue is pretty critical because it affects `work.ubq.f… | 6.8content: p: count: 31 score: 1 code: count: 2 score: 1 a: count: 1 score: 1 wordValue: 0.2 formattingMultiplier: 1 | 0.7 | 4.76 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.22 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@rndquu since we opened a new pr here we can close #30 as not pl… | 1.1content: p: count: 44 score: 1 wordValue: 0.1 formattingMultiplier: 0.25 | 0.2 | 0.22 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 4 | 4.9 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
You make your own directory and test against it | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.1 | 0.09 |
@gentlementlegen it didnt collect any review comments this time. | 0.9content: p: count: 9 score: 1 wordValue: 0.1 formattingMultiplier: 1 | - | - |
Hmm should we make a dedicated GitHub app for this purpose? It s… | 1.4content: p: count: 14 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.8 | 1.12 |
I think it looks more professional to use a bot instead of a per… | 4.1content: p: count: 41 score: 1 wordValue: 0.1 formattingMultiplier: 1 | 0.9 | 3.69 |
@0x4007 I think we were getting better relevance results doing an average for sure, I mean Rndquu's relevance here more than doubled between these two permit events which is pretty wild when you consider issues with lots of big comments.
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Task | 1 | 150 |
Issue | Comment | 5 | 0 |
Review | Comment | 9 | 44.3 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Out at the moment but was tasked with this earlier on TG. I hav… | 0content: p: symbols: \b\w+\b: count: 42 multiplier: 0 score: 1 multiplier: 0 | 0.4 | - |
I think this needs re-opened as the run isn't deleting issues ([… | 0content: p: symbols: \b\w+\b: count: 20 multiplier: 0 score: 1 a: symbols: \b\w+\b: count: 2 multiplier: 0 score: 1 ul: symbols: \b\w+\b: count: 25 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 6 multiplier: 0 score: 1 hr: symbols: \b\w+\b: count: 1 multiplier: 0 score: 0 code: symbols: \b\w+\b: count: 1 multiplier: 0 score: 1 multiplier: 0 | 0.9 | - |
- https://docs.github.com/en/rest/authentication/permissions-req… | 0content: ul: symbols: \b\w+\b: count: 106 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 106 multiplier: 0 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0 score: 1 multiplier: 0 | 0.8 | - |
![image](https://github.com/user-attachments/assets/f2821b01-7ba… | 0content: h2: symbols: \b\w+\b: count: 1 multiplier: 0 score: 1 img: symbols: \b\w+\b: count: 1 multiplier: 0 score: 0 p: symbols: \b\w+\b: count: 22 multiplier: 0 score: 1 ul: symbols: \b\w+\b: count: 54 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 16 multiplier: 0 score: 1 code: symbols: \b\w+\b: count: 3 multiplier: 0 score: 1 h6: symbols: \b\w+\b: count: 3 multiplier: 0 score: 1 multiplier: 0 | 0.85 | - |
@0x4007 I think we were getting better relevance results doing a… | 0content: p: symbols: \b\w+\b: count: 41 multiplier: 0 score: 1 multiplier: 0 | 0.1 | - |
@jordan-ae tests have failed If it's not possible to delete iss… | 11.3content: p: symbols: \b\w+\b: count: 111 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 11.3 |
I can [delete issues](https://github.com/ubq-testing/devpool-dir… | 7.7content: p: symbols: \b\w+\b: count: 74 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 img: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 0 multiplier: 1 | 1 | 7.7 |
EDIT: My mistake, I thought for a sec the original spec was a se… | 2.1content: p: symbols: \b\w+\b: count: 19 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.1 |
@jordan-ae I'm not certain but it's likely your token/permission… | 10.9content: p: symbols: \b\w+\b: count: 109 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 10.9 |
I guess it can be either a step in the workflow or included in t… | 8.5content: p: symbols: \b\w+\b: count: 85 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 8.5 |
- https://github.com/ubiquity/devpool-directory/issues/1334 @rn… | 3.8content: ul: symbols: \b\w+\b: count: 19 multiplier: 0.1 score: 1 li: symbols: \b\w+\b: count: 19 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 3.8 |
Resolves https://github.com/ubiquity/devpool-directory-bounties/… | 0content: p: symbols: \b\w+\b: count: 9 multiplier: 0 score: 1 ul: symbols: \b\w+\b: count: 133 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 17 multiplier: 0 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0 score: 1 hr: symbols: \b\w+\b: count: 1 multiplier: 0 score: 0 ol: symbols: \b\w+\b: count: 34 multiplier: 0 score: 0 multiplier: 0 | 0.95 | - |
[I see it failed](https://github.com/ubiquity/devpool-directory/… | 0content: p: symbols: \b\w+\b: count: 27 multiplier: 0.2 score: 1 a: symbols: \b\w+\b: count: 4 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
QA: https://github.com/ubiquity/devpool-directory/actions/runs/1… | 0content: p: symbols: \b\w+\b: count: 24 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 img: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 0 multiplier: 0 | 1 | - |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Specification | 1 | 41.4 |
Issue | Comment | 2 | 6.28 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
Original [comment](https://github.com/ubiquity/devpool-directory… | 41.4content: p: symbols: \b\w+\b: count: 67 multiplier: 0.1 score: 1 a: symbols: \b\w+\b: count: 2 multiplier: 0.1 score: 5 code: symbols: \b\w+\b: count: 5 multiplier: 0.1 score: 5 ul: symbols: \b\w+\b: count: 64 multiplier: 0.1 score: 0 li: symbols: \b\w+\b: count: 36 multiplier: 0.1 score: 1 ol: symbols: \b\w+\b: count: 46 multiplier: 0.1 score: 0 multiplier: 3 | 1 | 41.4 |
There's already a similar issue https://github.com/ubiquity/devp… | 8.6content: p: symbols: \b\w+\b: count: 43 multiplier: 0.2 score: 1 multiplier: 1 | 0.3 | 2.58 |
This issue is pretty critical because it affects `work.ubq.f… | 7.4content: p: symbols: \b\w+\b: count: 34 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 2 multiplier: 0.2 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 1 | 0.5 | 3.7 |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 1 | 0.235 |
Review | Comment | 4 | 0 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
@rndquu since we opened a new pr here we can close #30 as not pl… | 1.175content: p: symbols: \b\w+\b: count: 47 multiplier: 0.1 score: 1 multiplier: 0.25 | 0.2 | 0.235 |
Resolves [#31](https://github.com/ubiquity/devpool-directory-bou… | 0content: p: symbols: \b\w+\b: count: 51 multiplier: 0 score: 1 a: symbols: \b\w+\b: count: 3 multiplier: 0 score: 1 strong: symbols: \b\w+\b: count: 2 multiplier: 0 score: 0 ul: symbols: \b\w+\b: count: 198 multiplier: 0 score: 1 li: symbols: \b\w+\b: count: 35 multiplier: 0 score: 1 multiplier: 0 | 0.9 | - |
@Keyrxng i attempt to do do several times during the day unsucce… | 0content: p: symbols: \b\w+\b: count: 20 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
@Keyrxng I've given deleting issues a try again and still not be… | 0content: p: symbols: \b\w+\b: count: 57 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 120 multiplier: 0.2 score: 1 img: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 0 pre: symbols: \b\w+\b: count: 120 multiplier: 0.2 score: 0 multiplier: 0 | 1 | - |
Btw @Keyrxng & @rndquu is it okay if I add a `delete un… | 0content: p: symbols: \b\w+\b: count: 51 multiplier: 0.2 score: 1 code: symbols: \b\w+\b: count: 3 multiplier: 0.2 score: 1 a: symbols: \b\w+\b: count: 1 multiplier: 0.2 score: 1 multiplier: 0 | 1 | - |
View | Contribution | Count | Reward |
---|---|---|---|
Issue | Comment | 4 | 4.29 |
Review | Comment | 4 | 11.9 |
Comment | Formatting | Relevance | Reward |
---|---|---|---|
You make your own directory and test against it | 0.9content: p: symbols: \b\w+\b: count: 9 multiplier: 0.1 score: 1 multiplier: 1 | 0.1 | 0.09 |
@gentlementlegen it didnt collect any review comments this time. | 0content: p: symbols: \b\w+\b: count: 9 multiplier: 0.1 score: 1 multiplier: 1 | - | - |
Hmm should we make a dedicated GitHub app for this purpose? It s… | 1.4content: p: symbols: \b\w+\b: count: 14 multiplier: 0.1 score: 1 multiplier: 1 | 0.8 | 1.12 |
I think it looks more professional to use a bot instead of a per… | 4.4content: p: symbols: \b\w+\b: count: 44 multiplier: 0.1 score: 1 multiplier: 1 | 0.7 | 3.08 |
I assume this is only for bots. I suppose thats fine because hum… | 1.9content: p: symbols: \b\w+\b: count: 19 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 1.9 |
Please don't do this with having to add an extra secret PAT when… | 5.7content: p: symbols: \b\w+\b: count: 35 multiplier: 0.1 score: 1 pre: symbols: \b\w+\b: count: 22 multiplier: 0.1 score: 0 code: symbols: \b\w+\b: count: 22 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 5.7 |
Also can you confirm that this script works? I'm pretty sure the… | 2content: p: symbols: \b\w+\b: count: 19 multiplier: 0.1 score: 1 code: symbols: \b\w+\b: count: 1 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2 |
I am assuming that the bot auth token acts the same as a PAT so … | 2.3content: p: symbols: \b\w+\b: count: 23 multiplier: 0.1 score: 1 multiplier: 1 | 1 | 2.3 |
@0x4007 Here you have results with the correct fetching of the linked pull-request. GraphQl is definitely more reliable to get this info.
Doesn't make sense that keyrxng got review rewards as the assignee @gentlementlegen
There are two pull requests linked to this issue. One he is, one he is not. What should we do about it?
He is the assignee to this issue. Doesn't matter how many pulls, he should not be eligible for review incentives.
There is a different multiplier for ISSUE_AUTHOR
and PULL_AUTHOR
as well as PULL_ASSIGNED
and ISSUE_ASSIGNEE
.
Keyrxng is:
ISSUE_ASSIGNEE
on https://github.com/ubiquity/devpool-directory-bounties/issues/31PULL_AUTHOR
on https://github.com/ubiquity/devpool-directory/pull/1341PULL_COLLABORATOR
on https://github.com/ubiquity/devpool-directory/pull/1330Which is why the second one rewards him. This would imply changing the whole logic to look at the originally assigned user to the issue from the PR and then consider the relationship to be ISSUE_ASSIGNED
to override the PULL_COLLABORATOR
. I do not know how v1 worked on this regard (with the bug it had it would reward everything regardless).
It didn't reward assignees for reviews.
There is a hierarchy of roles and each contributor is selected as the highest rank role that they are eligible for. I forget if issue author or assignee is the top ranking role, but I'm thinking it must have been assignee for it to work as it did.
https://github.com/ubiquibot/conversation-rewards/issues/29#issuecomment-2222260068
I got rewarded for my comments on the PR, while I was assigned to the Issue and author of the PR, so I thought it was a normal scenario.
Then when checking the pull-request I will look back at its original issue and check if that person is assigned.
Make sure to review from before you started making changes to the plugin. It is possible that you introduced a bug. Look at how I implemented it originally (cross reference commit times and permit timestamps) it was important that it did not reward assignees for reviews because thats too easily exploitable.
Pretty sure that the v2 always rewarded assignees of the issue but in 99% of them, the PR author was the same as the issue, so a multiplier of 0
was applied to both. Here is a rare case when multiple PRs and assigned users happened on the same issue.
Original comment
Right now anybody can create a new github issue in https://github.com/ubiquity/devpool-directory and it will be displayed at
work.ubq.fi
:Allowing anybody to create issues in https://github.com/ubiquity/devpool-directory is not optimal because:
work.ubq.fi
with issues (illustrated on the screenshot above)work.ubq.fi
One of the solutions could be to remove issues from https://github.com/ubiquity/devpool-directory if they're opened not by one of the following bots (id => github URL):
76412717: https://github.com/ubiquity
133917611: https://github.com/ubiquibot
165700353: https://github.com/UbiquityOS
P.S. There is also the limit interaction option but if we enable it then new contributors won't be able to open PRs towards https://github.com/ubiquity/devpool-directory