ubiquity / nft-rewards

Set of contracts that allow minter to sign off-chain mint requests for target users who can later mint NFTs using the minter's signature
0 stars 4 forks source link

Invalidate nonce #4

Closed rndquu closed 8 months ago

rndquu commented 9 months ago

Owner should be able to invalidate nonce for already signed mint request.

What should be done:

  1. Add a new method invalidateNonce() where owner can pass a nonce value and invalidate mint request.
  2. Cover with tests the invalidateNonce() method
ubiquibot[bot] commented 9 months ago
! action has an uncaught error
ubiquibot[bot] commented 9 months ago
! action has an uncaught error
gpylypchuk commented 8 months ago

Do you mean a method like this?

function invalidateNonce(uint256 _nonceValue) external onlyOwner {
        nonceRedeemed[_nonceValue] = true;
}

So when your're going to mint, that nonce is already used and the require should fail.

rndquu commented 8 months ago

Do you mean a method like this?

function invalidateNonce(uint256 _nonceValue) external onlyOwner {
        nonceRedeemed[_nonceValue] = true;
}

So when your're going to mint, that nonce is already used and the require should fail.

Exactly

gpylypchuk commented 8 months ago

/start

ubiquibot[bot] commented 8 months ago
! Too many assigned issues, you have reached your max limit
ubiquibot[bot] commented 8 months ago
! action has an uncaught error
molecula451 commented 8 months ago
! action has an uncaught error
ubiquibot[bot] commented 8 months ago
! action has an uncaught error
molecula451 commented 8 months ago

/query @gpylypchuk

ubiquibot[bot] commented 8 months ago
Property Value
Wallet 0x3ac293A770B62F7fECCe918dCC361a594b7f68eA
molecula451 commented 8 months ago

thanks for the PR @gpylypchuk hold while we get you the bot generate the permit claim to you

gpylypchuk commented 8 months ago

thanks for the PR @gpylypchuk hold while we get you the bot generate the permit claim to you

yes! no problem :)

0x4007 commented 8 months ago

Weird that it didn't even start the process here. Maybe I broke it by changing the GitHub secret in the other organization. Although I would've expected a crash after the calculating rewards comment is posted.

molecula451 commented 8 months ago

yeah it looks like on the last action it throw the key/pair incorrect that we know

ubiquibot[bot] commented 8 months ago
! action has an uncaught error
molecula451 commented 8 months ago

pavlovcik let's not forget to issue this contributors permit

ubiquibot[bot] commented 8 months ago
+ Evaluating results. Please wait...
0x4007 commented 8 months ago

We can try regenerating here.

ubiquibot[bot] commented 8 months ago

[ 4.2 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueComment24.2
Conversation Incentives
CommentFormattingRelevanceReward
Weird that it didn't even start the process here. Maybe I broke ...
3.70.013.7
We can try regenerating here....
0.50.010.5

[ 5.5 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueComment45.5
Conversation Incentives
CommentFormattingRelevanceReward
> ```diff > ! action has an uncaught error > ``` ...
1
code:
  count: 1
  score: "1"
  words: 0
0.91
thanks for the PR @gpylypchuk hold while we get you the bot gene...
1.80.021.8
yeah it looks like on the last action it throw the key/pair inco...
1.70.021.7
pavlovcik let's not forget to issue this contributors permit...
1-1

[ 26.2 WXDAI ]

@gpylypchuk
Contributions Overview
ViewContributionCountReward
IssueTask1.0025
IssueComment20
ReviewComment11.2
Conversation Incentives
CommentFormattingRelevanceReward
Do you mean a method like this? ```solidity function invalid...
-
code:
  count: 1
  score: "0"
  words: 0
1-
> thanks for the PR @gpylypchuk hold while we get you the bot ge...
---
> looking good but it left to desire a bit, @gpylypchuk can you ...
1.2
code:
  count: 1
  score: "1"
  words: 1
0.951.2

[ 13.8 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification112.6
IssueComment11.2
Conversation Incentives
CommentFormattingRelevanceReward
Owner should be able to invalidate [nonce](https://github.com/ub...
12.6
a:
  count: 1
  score: "1"
  words: 1
li:
  count: 2
  score: "2"
  words: 26
code:
  count: 2
  score: "2"
  words: 2
112.6
> Do you mean a method like this? > > ```solidity > function...
1.2
code:
  count: 1
  score: "1"
  words: 0
11.2