chore: fix knip warnings in onboarding repository

ubiquity / onboard.ubq.fi

onboard.ubq.fi

0 stars 6 forks source link

chore: fix knip warnings in onboarding repository #19

Closed gitcoindev closed 7 months ago

gitcoindev commented 7 months ago

Set correct entry points in knip.ts for onboarding repostiory to find all dependencies
add unlisted transitive dependencies to package.json that were imported directly
add no-unused-vars to two unused exports

Resolves #18

QA: merged to fork and tested at https://github.com/gitcoindev/onboard.ubq.fi/pull/4

Also tested against local workspace:

$ yarn knip
yarn run v1.22.19
$ knip
✂️  Excellent, Knip found no issues.
Done in 4.17s.

github-actions[bot] commented 7 months ago

Unused dependencies (2)

Filename	dependencies
package.json	`@supabase/supabase-js` `@ubiquibot/configuration`

gitcoindev commented 7 months ago

@rndquu this should fix the Knip configuration and https://github.com/ubiquity/onboard.ubq.fi/pull/14 should be also passing aftwards. I also got the comment above about @supabase/supabase-js and @ubiquibot/configuration in my fork when I did QA, after merging it will disappear.

I am going to fix all Knip configurations this week, if you know any other repository that needs the configuration change please let me know.