ubiquity / onboard.ubq.fi

onboard.ubq.fi
0 stars 6 forks source link

Fix defaultConf.keys is undefined - Refactor onboarding.ts #4

Closed molecula451 closed 8 months ago

molecula451 commented 8 months ago

Screenshot from 2024-03-02 03-23-08

Refactor: https://github.com/ubiquity/onboard.ubq.fi/blob/molecula-pr/static/scripts/onboarding/onboarding.ts to import new https://www.npmjs.com/package/@ubiquibot/configuration

Context:

https://github.com/ubiquity/onboard.ubq.fi/pull/1#issuecomment-1974292782 https://github.com/ubiquity/onboard.ubq.fi/pull/1#issuecomment-1974509479

gentlementlegen commented 8 months ago

/start

ubiquibot[bot] commented 8 months ago

DeadlineSat, Mar 2, 9:47 AM UTC
Registered Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED
Tips:
molecula451 commented 8 months ago

either point the fix to branch (if it's coming sooner) or we merge #1 (leave the good eyes) and you point to "development" the expect branch for on going refactor/development on this app (onboard). I would go for the second

molecula451 commented 8 months ago

@FernandVEYRIER git clone "development" tho

gentlementlegen commented 8 months ago

This issue depends on https://github.com/ubiquibot/configuration/issues/6 due to import issues inside a non-node environment.

molecula451 commented 8 months ago

This issue depends on ubiquibot/configuration#6 due to import issues inside a non-node environment.

yeah found those issues when importing aswell, that's why i opened the issue, because the package needed more debugging, then it only made sense that you've worked since the package still has few issues, btw i suggest a round readme on the package

ubiquibot[bot] commented 8 months ago
+ Evaluating results. Please wait...
ubiquibot[bot] commented 8 months ago

[ 52 WXDAI ]

@FernandVEYRIER
Contributions Overview
ViewContributionCountReward
IssueTask150
IssueComment10
IssueComment12
Conversation Incentives
CommentFormattingRelevanceReward
This issue depends on https://github.com/ubiquibot/configuration...
-0.9-
This issue depends on https://github.com/ubiquibot/configuration...
20.92

[ 31.2 WXDAI ]

@molecula451
Contributions Overview
ViewContributionCountReward
IssueSpecification19.8
IssueComment321.4
Conversation Incentives
CommentFormattingRelevanceReward
![Screenshot from 2024-03-02 03-23-08](https://github.com/ubiqui...
9.819.8
either point the fix to [branch](https://github.com/ubiquity/onb...
9.4
a:
  count: 1
  score: "1"
  words: 1
0.7759.4
@FernandVEYRIER `git clone` "development" tho...
2
code:
  count: 1
  score: "1"
  words: 2
0.662
> This issue depends on [ubiquibot/configuration#6](https://gith...
10
a:
  count: 1
  score: "1"
  words: 3
0.72510