ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)
https://pay.ubq.fi
8 stars 28 forks source link

Redo Carousel #196

Open 0x4007 opened 3 months ago

0x4007 commented 3 months ago

I think the aesthetics are not good with the carousel.

localhost_8080__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNzk2NDgxODQwMDA5MzQ0ODI4NzA0NjE0NjAzMDE2NDE5NzU4NTM0Nz

Instead we should render all the permits vertically stacked all at once. Something like the following:

localhost_8080__claim=W3sidHlwZSI6ImVyYzIwLXBlcm1pdCIsInBlcm1pdCI6eyJwZXJtaXR0ZWQiOnsidG9rZW4iOiIweGU5MUQxNTNFMGI0MTUxOEEyQ2U4RGQzRDc5NDRGYTg2MzQ2M2E5N2QiLCJhbW91bnQiOiIwIn0sIm5vbmNlIjoiNzk2NDgxODQwMDA5MzQ0ODI4NzA0NjE0NjAzMDE2NDE5NzU4NT (1)

I suspect that we will need to redo quite a bit of logic, as the app seems to be designed only to render one at a time.

devpanther commented 3 months ago

/start

ubiquibot[bot] commented 3 months ago

DeadlineTue, Mar 12, 5:40 PM UTC
Registered Wallet 0xf76F1ACB66020f893c95371f740549F312DEA3f1
Tips:
el-buku commented 3 months ago

Still available?

devpanther commented 3 months ago

No, on it

0x4007 commented 3 months ago

No, on it

You should have at least a draft pull open to retain this task

devpanther commented 3 months ago

No, on it

You should have at least a draft pull open to retain this task

I will get one open soon, too many files to change.. wasn't a 1 day task as a lot would easily break

ubiquibot[bot] commented 3 months ago
# No linked pull requests to close
jordan-ae commented 3 months ago

@pavlovcik Since the list might get quite long isn't it necessary to implement some form of pagination here? Probably after 10 permits, we should break to the next page. It will improve the UX significantly in my opinion.

0x4007 commented 3 months ago

Makes sense but I think in the near term let's not worry about that. The only planned behavior for multi permit payouts is something like 1. Stablecoin 2. Governance token reward 3. NFT POAP reward.

So the most I expect to support is three for our near term vision.

jordan-ae commented 3 months ago

/start

ubiquibot[bot] commented 3 months ago

DeadlineThu, Mar 28, 12:58 PM UTC
Registered Wallet 0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5
Tips:
jordan-ae commented 3 months ago

@pavlovcik and @rndquu,

I'm currently working on setting up a repository, and I've been following the instructions provided in the README. Although I managed to start the application, I'm encountering an issue where it continuously loads without rendering any actual data.

Could you please offer some guidance on troubleshooting steps to get the application working as intended? Any insights or suggestions would be greatly appreciated. Thank you!

rndquu commented 3 months ago

@pavlovcik and @rndquu,

I'm currently working on setting up a repository, and I've been following the instructions provided in the README. Although I managed to start the application, I'm encountering an issue where it continuously loads without rendering any actual data.

Could you please offer some guidance on troubleshooting steps to get the application working as intended? Any insights or suggestions would be greatly appreciated. Thank you!

In order for any data to be displayed the claim URL query parameter should be provided which contains all of the data (example).

You may generate test claim URLs with this script. If the app is still loading continuously the issue is somewhere else.

jordan-ae commented 3 months ago

@rndquu I'm using the ERC721 url generated in the terminal. I'm getting a CORS error in the console.

Screenshot 2024-03-29 at 01 12 32

0x4007 commented 3 months ago

Try now https://github.com/ubiquity/pay.ubq.fi/pull/213

Be sure to pull

jordan-ae commented 3 months ago

Try now #213

Be sure to pull

Works now Thanks

ubiquibot[bot] commented 3 weeks ago
# These linked pull requests are closed:  <a href="https://github.com/ubiquity/pay.ubq.fi/pull/216">#216</a>