Reward Amount Decimal Not Accurate

ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)

https://pay.ubq.fi

8 stars 36 forks source link

Reward Amount Decimal Not Accurate #210

Closed 0x4007 closed 6 months ago

0x4007 commented 6 months ago

I made a mistake with rendering the decimals. This reward is actually for 94.6 WXDAI.

Make sure that if the reward is actually for 95 WXDAI to not render the decimal. Otherwise render the minimum amount of decimals, with a max of four significant digits, in case the asset is something expensive like ether.

ubiquibot[bot] commented 6 months ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 6 months ago

[ 11 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	11

Conversation Incentives

Comment	Formatting	Relevance	Reward
I made a mistake with rendering the decimals. This reward is act...	11	1	11

0x4007 commented 6 months ago

Weird it didn't automatically assign you @Keyrxng. Can you try to self assign?

Keyrxng commented 6 months ago

/start

ubiquibot[bot] commented 6 months ago




Deadline Mon, Mar 25, 11:01 AM UTC

Registered Wallet
0xAe5D1F192013db889b1e2115A370aB133f359765

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Keyrxng commented 6 months ago

it does that to me quite often, it's my own fault I need to stop pushing PRs without starting the task first

ubiquibot[bot] commented 6 months ago

+ Evaluating results. Please wait...

0x4007 commented 6 months ago

it does that to me quite often, it's my own fault I need to stop pushing PRs without starting the task first

Its supposed to handle this situation thats why I'm surprised. Perhaps it only does so on draft pulls

ubiquibot[bot] commented 6 months ago

[ 17.6 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	11
Issue	Comment	2	6.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
I made a mistake with rendering the decimals. This reward is act...	11	1	11
Weird it didn't automatically assign you @Keyrxng. Can you try t...	2.8	0.18	2.8
> it does that to me quite often, it's my own fault I need to st...	3.8	0.31	3.8

[ 25 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	25
Issue	Comment	1	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
it does that to me quite often, it's my own fault I need to stop...	-	0.29	-

Deadline	Mon, Mar 25, 11:01 AM UTC
Registered Wallet	0xAe5D1F192013db889b1e2115A370aB133f359765