Permit Invalidation Does Not Work

0x4007 commented 1 month ago

I tried invalidating a permit and got this error.

erc20-permit.ts:255 TypeError: Cannot read properties of undefined (reading 'nonce')
    at HTMLButtonElement.invalidateButtonClickHandler (erc20-permit.ts:251:57)
invalidateButtonClickHandler    @   erc20-permit.ts:255

Keyrxng commented 1 month ago

/start

ubiquibot[bot] commented 1 month ago




Deadline Wed, May 29, 3:16 AM UTC

Registered Wallet
0xAe5D1F192013db889b1e2115A370aB133f359765

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

ubiquibot[bot] commented 1 month ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 1 month ago

[ 40.8 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	13.2
Review	Comment	1	27.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
I tried invalidating a permit and got this error. ``` erc20-...	13.2 code: count: 1 score: "1" words: 0	1	13.2
> \| Preview Deployment \| > \| ------------------ \| > \| [...	27.6 a: count: 2 score: "4" words: 2 td: count: 2 score: "4" words: 8	0.51	27.6

[ 8 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	8

Conversation Incentives

Comment	Formatting	Relevance	Reward
@0x4007 Sadly back to the problem with the env missing on `pull_...	8 code: count: 3 score: "3" words: 3	0.59	8

[ 204.4 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Review	Comment	2	4.4

Conversation Incentives

Comment	Formatting	Relevance	Reward
CI failed because of `nonce too low` again ![image](https://g...	1.8 code: count: 1 score: "1" words: 3	0.75	1.8
@rndquu all passing, the new setup scripts seem like they are do...	2.6	0.62	2.6

[ 3 WXDAI ]

@rndquu

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	3

Conversation Incentives

Comment	Formatting	Relevance	Reward
> CI failed because of `nonce too low` again > > ![i...	3 code: count: 2 score: "2" words: 4	0.64	3

ubiquibot-v2-testing[bot] commented 1 month ago

[ 209.848 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Review	Comment	3	9.848

Conversation Incentives

Comment	Formatting	Relevance	Reward
Resolves #227 - correct prop access typo - add test for invalid…	0 p: count: 13 score: 1	0.79	-
CI failed because of `nonce too low` again ![image](https://gith…	4.4 p: count: 8 score: 1 code: count: 3 score: 1 img: count: 1 score: 0	0.67	2.948
@rndquu all passing, the new setup scripts seem like they are do…	10 p: count: 25 score: 1	0.69	6.9

[ 9.622 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	3.888
Review	Comment	1	5.734

Conversation Incentives

Comment	Formatting	Relevance	Reward
I tried invalidating a permit and got this error. ``` erc20-perm…	4.8 p: count: 33 score: 1 code: count: 15 score: 1	0.81	3.888
@gentlementlegen perhaps we should remove this feature because …	9.4 p: count: 94 score: 1	0.61	5.734

[ 1.731 WXDAI ]

@rndquu

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	2	1.731

Conversation Incentives

Comment	Formatting	Relevance	Reward
Works fine @Keyrxng Also thank you for your efforts with https:/…	1.5 p: count: 15 score: 1	0.56	0.84
Could you merge the latest `development` branch and try again?	1.1 p: count: 10 score: 1 code: count: 1 score: 1	0.81	0.891

[ 6.206 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	2	6.206

Conversation Incentives

Comment	Formatting	Relevance	Reward
Ran tests locally, all successful. My only remark would be that …	3 p: count: 29 score: 1 code: count: 1 score: 1	0.63	1.89
@0x4007 Sadly back to the problem with the env missing on `pull_…	5.2 p: count: 49 score: 1 code: count: 3 score: 1	0.83	4.316

ubiquibot[bot] commented 1 month ago

# These linked pull requests are closed:  <a href="https://github.com/ubiquity/pay.ubq.fi/pull/231">#231</a>

ubiquibot[bot] commented 1 month ago

@Keyrxng the deadline is at 2024-05-31T10:39:42.168Z

ubiquibot[bot] commented 1 month ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 1 month ago

[ 40.8 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	13.2
Review	Comment	1	27.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
I tried invalidating a permit and got this error. erc20-...	13.2 code: count: 1 score: "1" words: 0	1	13.2
> \| Preview Deployment \| > \| ------------------ \| > \| [...	27.6 a: count: 2 score: "4" words: 2 td: count: 2 score: "4" words: 8	0.44	27.6

[ 8 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	8

Conversation Incentives

Comment	Formatting	Relevance	Reward
@0x4007 Sadly back to the problem with the env missing on `pull_...	8 code: count: 3 score: "3" words: 3	0.57	8

[ 204.4 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Review	Comment	2	4.4

Conversation Incentives

Comment	Formatting	Relevance	Reward
CI failed because of `nonce too low` again ![image](https://g...	1.8 code: count: 1 score: "1" words: 3	0.67	1.8
@rndquu all passing, the new setup scripts seem like they are do...	2.6	0.68	2.6

[ 3 WXDAI ]

@rndquu

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	3

Conversation Incentives

Comment	Formatting	Relevance	Reward
> CI failed because of `nonce too low` again > > ![i...	3 code: count: 2 score: "2" words: 4	0.56	3

ubiquibot-v2-testing[bot] commented 1 month ago

[ 209.08 WXDAI ]

@Keyrxng

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	200
Review	Comment	3	9.08

Conversation Incentives

Comment	Formatting	Relevance	Reward
Resolves #227 - correct prop access typo - add test for invalid…	0 p: count: 13 score: 1	0.79	-
CI failed because of `nonce too low` again ![image](https://gith…	4.4 p: count: 8 score: 1 code: count: 3 score: 1 img: count: 1 score: 0	0.7	3.08
@rndquu all passing, the new setup scripts seem like they are do…	10 p: count: 25 score: 1	0.6	6

[ 9.95 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	3.84
Review	Comment	1	6.11

Conversation Incentives

Comment	Formatting	Relevance	Reward
I tried invalidating a permit and got this error. ``` erc20-perm…	4.8 p: count: 33 score: 1 code: count: 15 score: 1	0.8	3.84
@gentlementlegen perhaps we should remove this feature because …	9.4 p: count: 94 score: 1	0.65	6.11

[ 1.716 WXDAI ]

@rndquu

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	2	1.716

Conversation Incentives

Comment	Formatting	Relevance	Reward
Works fine @Keyrxng Also thank you for your efforts with https:/…	1.5 p: count: 15 score: 1	0.55	0.825
Could you merge the latest `development` branch and try again?	1.1 p: count: 10 score: 1 code: count: 1 score: 1	0.81	0.891

[ 6.214 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	2	6.214

Conversation Incentives

Comment	Formatting	Relevance	Reward
Ran tests locally, all successful. My only remark would be that …	3 p: count: 29 score: 1 code: count: 1 score: 1	0.65	1.95
@0x4007 Sadly back to the problem with the env missing on `pull_…	5.2 p: count: 49 score: 1 code: count: 3 score: 1	0.82	4.264

Deadline	Wed, May 29, 3:16 AM UTC
Registered Wallet	0xAe5D1F192013db889b1e2115A370aB133f359765

ubiquity / pay.ubq.fi