ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)
https://pay.ubq.fi
8 stars 28 forks source link

fix: prop access and added test #231

Closed Keyrxng closed 1 month ago

Keyrxng commented 1 month ago

Resolves #227

ubiquibot-continuous-deploys[bot] commented 1 month ago
25555f1
f6b6f85
eccb5f0
github-actions[bot] commented 1 month ago
Preview Deployment
[25555f1d2b7267a86821633da74930418f611bfa]()
[f6b6f8581ab56185931c6e26ee56e62b146616cf]()
[eccb5f09fa0f475715f59e7e6b143377380e0532]()
Keyrxng commented 1 month ago

CI failed because of nonce too low again

image

rndquu commented 1 month ago

CI failed because of nonce too low again

image

Could you merge the latest development branch and try again?

Keyrxng commented 1 month ago

@rndquu all passing, the new setup scripts seem like they are doing the trick. Ofc it could still potentially fail but it's far less likely

0x4007 commented 1 month ago
Preview Deployment
[25555f1d2b7267a86821633da74930418f611bfa]()
[f6b6f8581ab56185931c6e26ee56e62b146616cf]()

@gentlementlegen perhaps we should remove this feature because it doesn't work where it's needed. I was going to test the pull now but the link is invalid. Or if you can fix this that would be ideal.

Alternatively we could create a "dev mode" menu on preview deployments to inject a permit. Perhaps we could generate it from the current active wallet so that we could also test invalidation etc. just a thought but also I'm a bit concerned that it's over engineered for the problem we are trying to solve (QA)

Reopened #195

gentlementlegen commented 1 month ago

@0x4007 Sadly back to the problem with the env missing on pull_request unlike pull_request_target. I'll see if we can use the same trick we do for Knip testing, where we trigger another workflow that will get the environment loaded. Otherwise we will have to add a dev mode indeed.