ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)
https://pay.ubq.fi
8 stars 28 forks source link

fix: deploy workflow properly posts urls to the deployment #232

Closed gentlementlegen closed 1 month ago

gentlementlegen commented 1 month ago

Resolves #195

ubiquibot-continuous-deploys[bot] commented 1 month ago
178998a
5f95dba
5f95dba
6488577
72a8777
github-actions[bot] commented 1 month ago
Preview Deployment
[178998a7cde19aab9341f5f09e0a4e955ed5cb67]()
[5f95dba0c375b96d7e5dfbecbf18ffc0d4a305bd]()
64885777f380e84aed74786f38635c429930a41d
72a877710b661a948628047b1a9089645bbdcaa5
gentlementlegen commented 1 month ago

Here is a workflow that worked with the fix: https://github.com/gentlementlegen/pay.ubq.fi/pull/15

My guess is that the env variable doesn't match the one in the Workflow file. I do not have access to the settings on this repo so if you could confirm @rndquu that I renamed it properly.

As it can be seen here and here all the other variables are populated and the secrets are enabled.

However it doesn't work on this PR because it seems to keep using the one in the development branch.

rndquu commented 1 month ago

Here is a workflow that worked with the fix: gentlementlegen#15

My guess is that the env variable doesn't match the one in the Workflow file. I do not have access to the settings on this repo so if you could confirm @rndquu that I renamed it properly.

As it can be seen here and here all the other variables are populated and the secrets are enabled.

However it doesn't work on this PR because it seems to keep using the one in the development branch.

You may use secrets.UBIQUIBOT_APP_PRIVATE_KEY_TEST. It is set to private key (with 0x prefix, not sure if etherjs handles it correctly) for 0xBA742bdBf4eF1e6be8a917Fd2f84BE6C74F8796B address which has all of the required allowances for using permit2 on gnosis chain. So everything should work once you start using secrets.UBIQUIBOT_APP_PRIVATE_KEY_TEST. I will DM you PK for future references.

gentlementlegen commented 1 month ago

@rndquu The third deployment inside https://github.com/ubiquity/pay.ubq.fi/pull/232#issuecomment-2141328179 seems to work fine with the test key, thank you.