ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)
https://pay.ubq.fi
8 stars 28 forks source link

Offramp link to docs #240

Open jordan-ae opened 3 weeks ago

jordan-ae commented 3 weeks ago

Resolves #239

Screen Shot 2024-06-19 at 11 51 27

Screenshot 2024-06-19 115213

ubiquibot-continuous-deploys[bot] commented 3 weeks ago
b9c736b
1bef856
5b6a02c
8ebb22d
9f6970c
a69236c
da7a837
5ff0cf9
30f33b3
github-actions[bot] commented 3 weeks ago
Preview Deployment
b9c736b62df1ac69df2051624d50cd30ab83e9a8
1bef8563c03ca8f15fb57e2a730316c6daa1c165
5b6a02ce290a57b212b39fb1ed26349c4c0e6f9a
8ebb22d9de25a0038b5655bde656f67deea61f49
9f6970cb8d8796466e2321948610e42e4ea6a59a
a69236cd39d5a471cb8dccbad5e124f6af490c03
da7a837eef89c9ddf8ca33336e22c062e5811110
30f33b3bab8a92a665930e8867d79f64e1b7bd0e
jordan-ae commented 3 weeks ago

You need to test that your deliverables work before you ask for reviews. It's not a link. It doesn't work.

Sorry about that my bad. I Assumed it was going to link and rushed through it. So sorry

Keyrxng commented 3 weeks ago

The notifications are misaligned which should not happen these should remain centred

image

jordan-ae commented 3 weeks ago

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

Keyrxng commented 3 weeks ago

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

You will notice it after wrapping the div, I was just highlighting it

Keyrxng commented 3 weeks ago

lmao I've been adding comments and seeing PENDING thinking that means that the changes to be made are pending.

I realise my mistake now, @jordan-ae can you see my comments? 😂

jordan-ae commented 3 weeks ago

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

You will notice it after wrapping the div, I was just highlighting it

I have wrapped the div but the alignment doesn't break. Any steps to repro this?

Keyrxng commented 3 weeks ago

The notifications are misaligned which should not happen these should remain centred

Crazy haven't experienced this. What size of screen are you viewing this on?

You will notice it after wrapping the div, I was just highlighting it

I have wrapped the div but the alignment doesn't break. Any steps to repro this?

other than an unstyled <a> not that I know of, if you can't repro that's probs a good thing.

0x4007 commented 3 weeks ago

You should match the styles of the #build element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.

jordan-ae commented 2 weeks ago

You should match the styles of the #build element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.

Fixed it the styles now match the build

rndquu commented 2 weeks ago

You should match the styles of the #build element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.

Fixed it the styles now match the build

@jordan-ae As far as I understand the commit hash should be horizontally aligned with the question sign, right now they're not on the same level, pls fix

Screenshot 2024-06-14 at 18 44 34
Keyrxng commented 1 week ago

Looks aligned when I pull locally on both mobile and desktop, notifications don't appear to be out of alignment either.

@jordan-ae for future aesthetic changes it would be nice if you could show a video of mobile and desktop or a screenshot of both., I would appreciate it and I try to do the same in my PRs

jordan-ae commented 1 week ago

Looks aligned when I pull locally on both mobile and desktop, notifications don't appear to be out of alignment either.

@jordan-ae for future aesthetic changes it would be nice if you could show a video of mobile and desktop or a screenshot of both., I would appreciate it and I try to do the same in my PRs

Thanks @Keyrxng I've updated the pr description to have screenshots of both mobile and desktop views.

Keyrxng commented 4 days ago

I noticed that it's doing this visible jumpy thing on page load which is far more noticeable with the help icon present but the commit hash does it too it was just harder to notice before.

@jordan-ae could you apply the same transition effects to the current <div class="footer"> that also happens to the pagination component, this way everything renders first and it doesn't get visibly pushed around?

You could:

It's looking better but it would look just a little better to not see it jumping around, thanks man.