Open jordan-ae opened 3 weeks ago
You need to test that your deliverables work before you ask for reviews. It's not a link. It doesn't work.
Sorry about that my bad. I Assumed it was going to link and rushed through it. So sorry
The notifications are misaligned which should not happen these should remain centred
The notifications are misaligned which should not happen these should remain centred
Crazy haven't experienced this. What size of screen are you viewing this on?
The notifications are misaligned which should not happen these should remain centred
Crazy haven't experienced this. What size of screen are you viewing this on?
You will notice it after wrapping the div, I was just highlighting it
lmao I've been adding comments and seeing PENDING
thinking that means that the changes to be made are pending.
I realise my mistake now, @jordan-ae can you see my comments? 😂
The notifications are misaligned which should not happen these should remain centred
Crazy haven't experienced this. What size of screen are you viewing this on?
You will notice it after wrapping the div, I was just highlighting it
I have wrapped the div but the alignment doesn't break. Any steps to repro this?
The notifications are misaligned which should not happen these should remain centred
Crazy haven't experienced this. What size of screen are you viewing this on?
You will notice it after wrapping the div, I was just highlighting it
I have wrapped the div but the alignment doesn't break. Any steps to repro this?
other than an unstyled <a>
not that I know of, if you can't repro that's probs a good thing.
You should match the styles of the #build
element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.
You should match the styles of the
#build
element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.
Fixed it the styles now match the build
You should match the styles of the
#build
element. Match the HTML structure as well. As of now the FAQ button and the footer look misaligned and sloppy.Fixed it the styles now match the build
@jordan-ae As far as I understand the commit hash should be horizontally aligned with the question sign, right now they're not on the same level, pls fix
Looks aligned when I pull locally on both mobile and desktop, notifications don't appear to be out of alignment either.
@jordan-ae for future aesthetic changes it would be nice if you could show a video of mobile and desktop or a screenshot of both., I would appreciate it and I try to do the same in my PRs
Looks aligned when I pull locally on both mobile and desktop, notifications don't appear to be out of alignment either.
@jordan-ae for future aesthetic changes it would be nice if you could show a video of mobile and desktop or a screenshot of both., I would appreciate it and I try to do the same in my PRs
Thanks @Keyrxng I've updated the pr description to have screenshots of both mobile and desktop views.
I noticed that it's doing this visible jumpy thing on page load which is far more noticeable with the help icon present but the commit hash does it too it was just harder to notice before.
@jordan-ae could you apply the same transition effects to the current <div class="footer">
that also happens to the pagination component, this way everything renders first and it doesn't get visibly pushed around?
You could:
displayCommitHash()
so that it is called at the top of the main body of renderTransaction()
#carousel
usesIt's looking better but it would look just a little better to not see it jumping around, thanks man.
Resolves #239