Closed Keyrxng closed 2 weeks ago
0x4007
commented
2 weeks ago time: < 1 hour
FYI we can consider making issue templates that will allow you to add a time label.
Example https://github.com/ubiquity/ubiquibar/tree/development/.github/ISSUE_TEMPLATE
Keyrxng
commented
2 weeks ago time: < 1 hour
FYI we can consider making issue templates that will allow you to add a time label.
Example https://github.com/ubiquity/ubiquibar/tree/development/.github/ISSUE_TEMPLATE
Those tees were so badass 😂
I like this idea but like you said on TG, I'm not fussed by it for as long as it's not an inconvenience to the team.
I was going to suggest it may be a good idea for contributors in general to have a template for suggesting a time estimate, although maybe not given their potential understanding of codebases
ubiquibot[bot]
commented
2 weeks ago + Evaluating results. Please wait...| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Comment | 1 | 2.6 |
| Review | Comment | 1 | 2.1 |
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
> time: < 1 hour FYI we can consider making issue templ... | 2.6 | 0.49 | 2.6 |
You can use any ChatGPT 4o processed version in place of your su... | 2.1 | 0.11 | 2.1 |
| View | Contribution | Count | Reward |
|---|---|---|---|
| Issue | Specification | 1 | 36.2 |
| Issue | Task | 1 | 50 |
| Issue | Comment | 1 | 13.2 |
| Issue | Comment | 1 | 0 |
| Review | Comment | 2 | 18.6 |
| Review | Comment | 2 | 9.3 |
| Comment | Formatting | Relevance | Reward |
|---|---|---|---|
Rather than have a generic fill-in-your-own approach with the re... | 36.2h5: count: 1 score: "1" words: 4 code: count: 3 score: "3" words: 8 | 1 | 36.2 |
> > time: < 1 hour > > FYI we can consider mak... | 13.2 | 0.445 | 13.2 |
> > time: < 1 hour > > FYI we can consider mak... | - | 0.445 | - |
> The level of detail is good on the README, but consider usi... | 14.6 | 0.67 | 14.6 |
https://github.com/ubiquity/pay.ubq.fi/actions/runs/9472156534/j... | 4 | 0.35 | 4 |
> The level of detail is good on the README, but consider usi... | 7.3 | 0.67 | 7.3 |
https://github.com/ubiquity/pay.ubq.fi/actions/runs/9472156534/j... | 2 | 0.35 | 2 |
Rather than have a generic fill-in-your-own approach with the readme it should have the default expected values to remove friction for new devs as there still seems to be some obscurity seeing the comment below.
This is one of the less complex codebases imo so comments like this are invaluable from non-Web3 natives.
The default config should be the same as the config used in tests, same wallet addresses, correct associated PK, correct RPC endpoint etc.
The reason why is we have
yarn test:anvil&yarn test:fundwhich handles the local setup e2e, they should only need to run these commands and be immediately able to claim the ERC20 permit generated withyarn start.Should a new small section be added to the readme, a layman's terms approach on exactly to do, ELI5-type step-by-step? Unsure if it's overkill considering the amount of info in it already.
time: < 1 hour