ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)
https://pay.ubq.fi
8 stars 28 forks source link

fix: readme #246

Closed Keyrxng closed 2 weeks ago

Keyrxng commented 2 weeks ago

Resolves #244

How relevant is everything underneath # How to test locally? I think it could be all be removed. There is auto-deploy for previews etc now so Cloudflare and hosting is irrelevant.

I think remove everything below and write a simplified walk through of the paths the UI can take and what is expected from things and when the amazon cards are released they can have their own section.

ubiquibot-continuous-deploys[bot] commented 2 weeks ago
4d32dac
1d197c6
049eae5
9992a62
77e6fb4
de16229
afa3835
692064b
114e59a
github-actions[bot] commented 2 weeks ago
Preview Deployment
4d32dac9de570ea55bcc20138ab6f5d171937c59
1d197c654c49ca9a05ab5efd8bc9dba41a744edb
9992a6243fde6aef972d5540740e8276fbdb5773
77e6fb4ad84d3f65d9f05fb4121344e7015a4d01
de162291170899228d9b839b310937d612e3ec03
afa383557d8a3a55c2c4e9c4e924b0a1d621f2d0
692064b5e578e921cc85572a55d42e2c087e8a4a
114e59acdf9a8413db757bcc636f9459d2e423b3
Keyrxng commented 2 weeks ago

The level of detail is good on the README, but consider using ChatGPT 4o to rewrite to make it as concise and clear as possible. I generally do this when I write long form content.

I will keep this in mind in the future, that readme you attached is a lot cleaner and direct. Should we use it in place of the suggestions you have made to my written version?

I have also had GPT4o rewrite it and had it keep the expected behaviour but tighten it up, I think I'd use it over my version as-is but I'm not 100% on what to do.

Keyrxng commented 2 weeks ago

https://github.com/ubiquity/pay.ubq.fi/actions/runs/9472156534/job/26097027405?pr=246

That's an interesting CI error

0x4007 commented 2 weeks ago

You can use any ChatGPT 4o processed version in place of your submission. Don't need to worry about my suggestions.