ubiquity / pay.ubq.fi

Generate and claim spender permits (EIP-2612)
https://pay.ubq.fi
10 stars 41 forks source link

Rate Limiting Can't Load All Assets #278

Closed 0x4007 closed 2 months ago

0x4007 commented 2 months ago

image

This happened to me twice already once on desktop, once on mobile where I noticed that the font is incorrect because it was unable to load the Proxima Nova font file.

When I checked the logs on desktop, it was because I was getting error 422 rate limited. I think we have too many assets and our Cloudflare rate limiting might be too strict.

We can consider minifying the assets and serving them in production. For example, combining all the CSS into a single file should solve this particular problem. I'm sure we can handle this in the build settings.

We can consider doing the same for JavaScript.

hhio618 commented 2 months ago

/start

ubiquityos[bot] commented 2 months ago
! Please set your wallet address with the /wallet command first and try again.
hhio618 commented 2 months ago

/wallet hhio618.eth

ubiquibot[bot] commented 2 months ago
- Resolving address from ENS name failed
ubiquityos[bot] commented 2 months ago

+ Successfully registered wallet address
hhio618 commented 2 months ago

/wallet 0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605

ubiquityos[bot] commented 2 months ago

+ Successfully registered wallet address
ubiquibot[bot] commented 2 months ago
+ Successfully registered wallet address
hhio618 commented 2 months ago

/start

ubiquityos[bot] commented 2 months ago
DeadlineMon, Aug 19, 10:30 AM UTC
Registered Wallet 0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605
Tips:
<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>
ubiquibot[bot] commented 2 months ago

DeadlineMon, Aug 19, 10:30 AM UTC
Registered Wallet 0x6321286F9B73f427C72e1f9F1bC6b3d25eF06605
Tips:
ubiquibot[bot] commented 2 months ago
+ Evaluating results. Please wait...
ubiquityos[bot] commented 2 months ago

[ 100 WXDAI ]

@hhio618
Contributions Overview
View Contribution Count Reward
Issue Task 1 100
Review Comment 4 0
Conversation Incentives
Comment Formatting Relevance Reward
Resolves #278 <!-- - You must link the issue number e.g. "…
0
content:
  p:
    count: 3
    score: 1
  ul:
    count: 18
    score: 0
  li:
    count: 18
    score: 1
wordValue: 0
formattingMultiplier: 0
0.1 -
@0x4007 This way I wanted to generate the exact look as the orig…
0
content:
  p:
    count: 84
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
As you can observe, the first line clears the file (the > sym…
0
content:
  p:
    count: 33
    score: 1
  code:
    count: 4
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -
I believe I've resolved the issue. Could you please verify? Add…
0
content:
  p:
    count: 31
    score: 1
wordValue: 0.2
formattingMultiplier: 0
1 -

[ 52.6 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Issue Specification 1 32.4
Review Comment 4 20.2
Conversation Incentives
Comment Formatting Relevance Reward
![image](https://github.com/user-attachments/assets/0040364a-a35…
32.4
content:
  p:
    count: 108
    score: 1
  img:
    count: 1
    score: 0
wordValue: 0.1
formattingMultiplier: 3
1 32.4
The compiled files should be git ignored probably, but otherwise…
4.2
content:
  p:
    count: 42
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 4.2
This seems wrong. This should be done dynamically. Besides this…
2.5
content:
  p:
    count: 25
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 2.5
That is a good point to specify the order. Ideally if we resol…
5.8
content:
  p:
    count: 58
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.8
I just checked on my computer now and it doesn't appear that the…
7.7
content:
  p:
    count: 63
    score: 1
  pre:
    count: 14
    score: 0
  code:
    count: 14
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 7.7

[ 21.6 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Review Comment 4 21.6
Conversation Incentives
Comment Formatting Relevance Reward
The UI on the right is [pay.ubq.fi](https://pay.ubq.fi) and ther…
7.7
content:
  p:
    count: 76
    score: 1
  a:
    count: 1
    score: 1
  img:
    count: 1
    score: 0
wordValue: 0.1
formattingMultiplier: 1
1 7.7
I had the same problem when rebuilding for [`NextJS`](ht…
4.6
content:
  p:
    count: 44
    score: 1
  a:
    count: 1
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 4.6
Great. Any optimizations that you spot and feel like including p…
3.9
content:
  p:
    count: 39
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 3.9
If you open up the actual deployment at [pay.ubq.fi](https://pay…
5.4
content:
  p:
    count: 53
    score: 1
  a:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
1 5.4
0x4007 commented 2 months ago

/help

ubiquityos[bot] commented 2 months ago

Available Commands

Command Description Example
/help List all available commands. /help
/allow Allows the user to modify the given label. /allow @user1 label
/query Returns the user's wallet, access, and multiplier information. /query @ubiquibot
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/wallet Register your wallet address for payments. /wallet ubq.eth
ubiquibot[bot] commented 2 months ago

Available Commands

Command Description Example
/start Assign yourself to the issue. /start
/stop Unassign yourself from the issue. /stop
/help List all available commands. /help
/query Returns the user's wallet, access, and multiplier information. /query @user
/ask Ask a context aware question. /ask is x or y the best approach?
/multiplier Set the task payout multiplier for a specific contributor, and provide a reason for why. /multiplier @user 0.5 "multiplier
reason"
/labels Set access control, for admins only. /labels @user priority time
price
/authorize Approve a label change, for admins only. /authorize
/wallet Register your wallet address for payments. /wallet ubq.eth
0x4007 commented 2 months ago

@ubiquity/software-development suspending ubiquibot (v1) now.

We just need the ability to set access control for labels.

gentlementlegen commented 2 months ago

This broke builds on Windows (sorry if I am the only hipster here). cat command is only Unix compliant. I'd suggest using cross platform commands or directly Node which is sure to run on any platform. Guilty code: https://github.com/ubiquity/pay.ubq.fi/blob/ec2fd20faab31b6ff1b924fa13ceea5ad15f90ea/build/esbuild-build.ts#L30

rndquu commented 1 month ago

@ubiquity/software-development suspending ubiquibot (v1) now.

We just need the ability to set access control for labels.

As far as I understand this is already implemented in the https://github.com/ubiquity-os-marketplace/assistive-pricing plugin.