Proxy issues - Githubissues

ubiquity / rpc-handler

RPC Handler NPM Package

2 stars 9 forks source link

Proxy issues #56

Open whilefoo opened 1 week ago

whilefoo commented 1 week ago

Because we are having problems with RPCs I looked at the code and found some quirks that I don't understand and some improvements that could be made.

@Keyrxng since you did this part, is there any reason why a JsonRpcProvider is wrapped with the Proxy two times, once here: https://github.com/ubiquity/rpc-handler/blame/7a24b8a491695bb2121d01e44f4e7a4745ec61e7/types/rpc-handler.ts#L271 and here: https://github.com/ubiquity/rpc-handler/blame/7a24b8a491695bb2121d01e44f4e7a4745ec61e7/types/rpc-handler.ts#L93 And is there a reason why we didn't just extend the BaseProvider from ethers?

Improvements:

When the RPC request fails it retries with the list of RPCs which includes this same RPC that failed, we should skip it instead.
If a RPC fails a couple of times even across different requests, we can mark it as offline and not use it anymore

0x4007 commented 1 week ago

Hey I just totally redid it

Notes:

It's really solid after first time initalization for a few seconds. then the fastest network is cached.

The test is way more robust, it actually downloads the smart contract code of permit2. The RPC endpoints cant lie about that response, like block height. They have to actually read the chain data correctly

https://github.com/0x4007/rpc2

Will install and test in pay.ubq.fi after I get some rest. If you're motivated you can work on integrating it for the next 12 hours or so.

whilefoo commented 1 week ago

How come you didn't use JsonRpcProvider from ethers? Without that we have to manually encode and decode data

0x4007 commented 1 week ago

I can probably make an adapter quite easily when I have more time

Keyrxng commented 5 days ago

Sorry guys I'll be back home tonight.

Probs missed it, but as far as I know pay.ubq.fi is running on V1.1 while this package currently sits at V1.3 so the actual proxy is not being used in pay.ubq.fi, unless these issues are occurring elsewhere or it was bumped in pay.ubq.fi and then reverted?

@whilefoo I'm sure it was because testRpcPerformance() can be called on it's own and it's possible that no class provider is set but looking at things it could be removed and that function made private as it's internal anyway after seeing the handler in use