ubiquity / ts-template

A template repository for all @ubiquity projects.
2 stars 24 forks source link

Deployments are not posted on pull requests #10

Closed 0x4007 closed 9 months ago

0x4007 commented 9 months ago

We already implemented this logic on the Ubiquity Dollar and pay.ubq.fi repositories, but it seems that it was overlooked within this template. The purpose of this is for reviewers to easily be able to review the work.

Example deployment comment: https://github.com/ubiquity/pay.ubq.fi/pull/148#issuecomment-1916873700

  1. Make sure to copy the code so that it works from this template.
  2. It seems sloppy. Refactor the code to be clean and all in TypeScript (or inside of GitHub Actions whatever makes more sense) and neatly organized inside of the .github directory.
  3. I can't find the example, but I realized that the commits are actually posting in reverse chronological order. This must be fixed.
0x4007 commented 9 months ago

/start

ubiquibot[bot] commented 9 months ago

DeadlineMon, Feb 19, 4:06 PM UTC
Registered Wallet 0x4007CE2083c7F3E18097aeB3A39bb8eC149a341d
Tips:
0x4007 commented 9 months ago

Kind of very messy, took me apparently about 10 hours to do, but here's the final result. Comments and pull requests supported:

https://github.com/ubiquity/ts-template/commit/6eb4ace9aff0ce51d1b09befa1b85e09c6eca81f#comments

ubiquibot[bot] commented 9 months ago
+ Evaluating results. Please wait...
ubiquibot[bot] commented 9 months ago

[ 240.8 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification135.4
IssueTask1.00200
IssueComment15.4
IssueComment10
Conversation Incentives
CommentFormattingRelevanceReward
We already implemented this logic on the Ubiquity Dollar and pay...
35.4
li:
  count: 5
  score: "5"
  words: 83
code:
  count: 1
  score: "1"
  words: 1
135.4
Kind of very messy, took me apparently about 10 hours to do, but...
5.40.225.4
Kind of very messy, took me apparently about 10 hours to do, but...
-0.22-
0x4007 commented 9 months ago

Just got it finalized. Was testing on this pull request, but the code changes are done on @ubiquity/cloudflare-continuous-deploys: https://github.com/ubiquity/ts-template/pull/14#issuecomment-1954346051