Closed Keyrxng closed 6 months ago
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
---|---|---|---|---|---|
All files | 92.3 | 75 | 80 | 92 | |
static | 80 | 100 | 66.66 | 80 | |
main.ts | 80 | 100 | 66.66 | 80 | 9 |
tests/kebab-case | 95.23 | 75 | 100 | 95 | |
kebab-case.ts | 95.23 | 75 | 100 | 95 | 20 |
@Keyrxng does it really need to be done manually? Have you considered using eslint
plugins instead like https://www.npmjs.com/package/eslint-plugin-filename-rules ? Or are there features missing in it
I wasn't aware of that plugin @gentlementlegen. The bash script was already in use in other repos across the org I just ported it over, added some tests and tweaks to catch more file name formats.
It could be removed in favour of the plugin I don't have any problems with that.
Also there is no active issue for this, I just took it upon myself (won't do it again without spinning up an issue first) but I'm happy to see it through and add the plugin if you haven't already took it upon yourself
Would be nice if you can test the plugin and see if that can replace everything that the script is currently doing. If so, I am in favor of replacing it by the eslint
package.
no worries I'll do this today
Would be nice if you can test the plugin and see if that can replace everything that the script is currently doing. If so, I am in favor of replacing it by the
eslint
package.
It'll have to be manual QA but seems to work nicely
@Keyrxng if you fix the conflicts in can merge this in.
@gentlementlegen sorry bud didn't see there was conflicts
Related to #21
eslint-plugin-filename-rules