Empty String `""` Code Review Warning Annotation

0x4007 commented 8 months ago

Annotate them with warnings in code review to more closely scrutinize the logic that interacts with the variable.

Rationale

I see a lot of abuse for empty strings. It makes code logic sloppy and more error prone. But since there are some legitimate uses for empty strings, we will just set a warning instead of error?

Examples

https://github.com/ubiquity/audit.ubq.fi/blob/08fba85a9a592ca2bda5eaeaa2ff3b9fdd4632be/static/scripts/audit-report/audit.ts#L26C1-L27C21

Should be unset (which implies undefined) instead of passing an empty string as a credential or URL. Then the code should check if the value is truthy before expecting authentication.
```
let REPOSITORY_URL;
let GITHUB_PAT;
```

https://github.com/ubiquity/ubiquibot-kernel/blame/c553d5a7866c1ef76d4f589d8095c8bb751cbd49/src/github/types/config.ts#L29

Should be value.ref ?? "@" + value.ref as I'm assuming the developer never expected the "" value to be returned there.

https://github.com/ubiquity/pay.ubq.fi/pull/189/files#r1518549017

This shouldn't have been here at all. It's not a valid RPC endpoint.

From codebase search: https://github.com/search?q=org%3Aubiquity+%5C%22%5C%22+language%3ATypeScript&type=code

Keyrxng commented 8 months ago

/start

ubiquibot[bot] commented 8 months ago




Deadline Mon, Mar 25, 8:54 AM UTC

Registered Wallet
0xAe5D1F192013db889b1e2115A370aB133f359765

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

Keyrxng commented 5 months ago

/stop if it is still an open task I will pick it back up. Feel free to ref my PR if anyone wants to take this

ubiquibot[bot] commented 5 months ago

+ You have been unassigned from the task

Sadaf-A commented 4 months ago

/start

ubiquibot[bot] commented 4 months ago



Warning!  This task was created over 118 days ago. Please confirm that this issue specification is accurate before starting.
Deadline Fri, Jul 5, 11:19 PM UTC

Registered Wallet
0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

ubiquibot[bot] commented 3 months ago

# These linked pull requests are closed:  <a href="https://github.com/ubiquity/ts-template/pull/36">#36</a>

jordan-ae commented 2 months ago

/start

ubiquity-os[bot] commented 2 months ago

Warning! This task was created over 179 days ago. Please confirm that this issue specification is accurate before starting. Deadline Wed, Sep 4, 6:21 PM UTC Registered Wallet 0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5

Tips:

<ul>
<li>Use <code>/wallet 0x0000...0000</code> if you want to update your registered payment wallet address.</li>
<li>Be sure to open a draft pull request as soon as possible to communicate updates on your progress.</li>
<li>Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.</li>
<ul>

ubiquity-os[bot] commented 2 months ago

@jordan-ae, this task has been idle for a while. Please provide an update.

jordan-ae commented 2 months ago

/stop

ubiquity-os[bot] commented 2 months ago


# These linked pull requests are closed:  https://github.com/ubiquity/ts-template/pull/57