ubiquity / ts-template

A template repository for all @ubiquity projects.
2 stars 24 forks source link

feat: empty string warning #36

Closed Keyrxng closed 5 months ago

Keyrxng commented 8 months ago

Resolves https://github.com/ubiquity/ts-template/issues/31

QA: https://github.com/ubq-testing/bot-ai/pull/31

github-actions[bot] commented 8 months ago
Lines Statements Branches Functions
Coverage: 80%
80% (4/5) 100% (0/0) 66.66% (2/3)

JUnit

Tests Skipped Failures Errors Time
1 0 :zzz: 0 :x: 0 :fire: 2.692s :stopwatch:
Coverage Report (80%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files8010066.6680 
   main.ts8010066.66809
Keyrxng commented 8 months ago

This was a mistake, meant to open it against my own dev branch and I don't have the option to close as unplanned lmao

gentlementlegen commented 8 months ago

@Keyrxng Just use this pull request as the final one, I converted it to a draft in the meantime.

Keyrxng commented 8 months ago

@FernandVEYRIER ready when you are mate

ubiquity-os-deployer[bot] commented 8 months ago
af57518
a61d62d
cdae93a
Keyrxng commented 8 months ago
rndquu commented 5 months ago

@Keyrxng Check this PR and this commit that assigns js variables empty strings.

The expected behaviour is that Empty string annotations should've been added, right?

Keyrxng commented 5 months ago

strange

it's identified the empty strings and their location and the GitHub UI is showing two comments but the comments are nowhere to be seen... any ideas why that might be off the top of your head? I'll see if I can debug the issue. I see it missed the one in static/main all together.

image

image

rndquu commented 5 months ago

any ideas why that might be off the top of your head?

Hard to say what went wrong