Three Letter Linter

[0x4007]

Make a custom lint rule enforcing this. Check previous conversation

Our coding style guide should have this written as Erc20Permit

It is an implicit rule according to the contributing.md in the Ubiquity Dollar repo

_Originally posted by @0x4007 in https://github.com/ubiquity/pay.ubq.fi/pull/224#discussion_r1569165738_

[gentlementlegen]

I think that PascalCase rule would be a better name for this issue 😄

[gitcoindev]

I think that PascalCase rule would be a better name for this issue 😄

or UpperCamelCase. But Three letter linter is a catchy name as it made me to click on this issue 😄

[jordan-ae]

@0x4007 should the linter ensure every variable respects PascalCase or just the Erc20Permit and Erc721 should follow this rule?

[jordan-ae]

/start

[ubiquibot[bot]]

Deadline	Fri, Apr 19, 12:23 PM UTC
Registered Wallet	0x2F05fD58023B0a95d1866aa0A3b672cEf05945c5

Tips:

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

[ubiquibot[bot]]

+ Evaluating results. Please wait...

[ubiquibot[bot]]

[ 15.8 WXDAI ]

@0x4007

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	3
Review	Comment	4	12.8

Conversation Incentives

Comment	Formatting	Relevance	Reward
Make a custom lint rule enforcing this. Check previous conversat...	3 code: count: 1 score: "1" words: 1	1	3
That rule seems to only check for the first character being capi...	7	0.76	7
I think let's use strictpascalcase then!...	1.4	0.84	1.4
Yes let's apply this across all identifiers. ...	1.6	0.765	1.6
We have lint-staged for this purpose but perhaps it's not config...	2.8	0.6	2.8

[ 21.4 WXDAI ]

@gentlementlegen

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	2.3
Review	Comment	3	19.1

Conversation Incentives

Comment	Formatting	Relevance	Reward
I think that `PascalCase` rule would be a better name for this i...	2.3 code: count: 1 score: "1" words: 1	0.63	2.3
There actually already is a rule for `PascalCase` interfaces, no...	9.6 code: count: 3 score: "3" words: 4	0.76	9.6
`StrictPascalCase` will enforce no more that one capital letter ...	6.3 code: count: 1 score: "1" words: 1	0.74	6.3
@0x4007 Shall this be applied to other elements too, like variab...	3.2 code: count: 1 score: "1" words: 1	0.85	3.2

[ 117.2 WXDAI ]

@jordan-ae

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1	100
Issue	Comment	1	0
Review	Comment	6	17.2

Conversation Incentives

Comment	Formatting	Relevance	Reward
@0x4007 should the linter ensure every variable respects PascalC...	-	0.53	-
> You also should not change any other files. @0x4007 The othe...	4.2	0.52	4.2
@0x4007, @gentlementlegen I've added StrictPascalCase to the es...	8.5	0.71	8.5
> We have lint-staged for this purpose but perhaps it's not conf...	1	0.54	1
@gentlementlegen please can you review? Thanks ...	0.6	0.645	0.6
Hey @0x4007 I've undone all the changes not related to the issue...	2	0.65	2
> I think let's use strictpascalcase then!I I thought we wer...	0.9	0.565	0.9

[ 2.9 WXDAI ]

@gitcoindev

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	2.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
> I think that `PascalCase` rule would be a better name for this...	2.9 code: count: 1 score: "1" words: 1	0.79	2.9