ubiquity / ts-template

A template repository for all @ubiquity projects.
2 stars 24 forks source link

Configure lint-staged hook correctly. #41

Closed jordan-ae closed 5 months ago

jordan-ae commented 7 months ago
          We have lint-staged for this purpose but perhaps it's not configured correctly.

Originally posted by @0x4007 in https://github.com/ubiquity/ts-template/issues/40#issuecomment-2071289984

gentlementlegen commented 6 months ago

@jordan-ae please provide a more in-depth description, and add a time estimate to it, thanks

rndquu commented 5 months ago

@jordan-ae please provide a more in-depth description, and add a time estimate to it, thanks

As far as I understand this issue implies fixing running husky hooks (lint-staged in particular) on github commit.

So we need to:

  1. Make sure husky is setup on yarn install (here it should be postinstall)
  2. Make sure ts files are linted on commit
jordan-ae commented 5 months ago

@gentlementlegen @rndquu this ticket might not need to exist. From my recent commits the lint-stage hook has been working correctly. We should close this as not planned.

ubiquibot[bot] commented 5 months ago
# Issue was not closed as completed. Skipping.
ubiquity-os-main[bot] commented 5 months ago

[ 0.255 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Issue Comment 1 0.255
Conversation Incentives
Comment Formatting Relevance Reward
@jordan-ae please provide a more in-depth description, and add a…
1.5
p:
  count: 15
  score: 1
0.17 0.255

[ 4.6 WXDAI ]

@rndquu
Contributions Overview
View Contribution Count Reward
Issue Comment 1 4.6
Conversation Incentives
Comment Formatting Relevance Reward
As far as I understand this issue implies fixing running husky h…
5
p:
  count: 45
  score: 1
code:
  count: 4
  score: 1
a:
  count: 1
  score: 1
0.92 4.6

[ 4.5 WXDAI ]

@jordan-ae
Contributions Overview
View Contribution Count Reward
Issue Specification 1 1.8
Issue Comment 1 2.7
Conversation Incentives
Comment Formatting Relevance Reward
We have lint-staged for this purpose but perhaps it's not config…
1.8
p:
  count: 18
  score: 1
em:
  count: 6
  score: 0
1 1.8
@gentlementlegen @rndquu this ticket might not need to exist. Fr…
5.4
p:
  count: 27
  score: 1
0.5 2.7