Closed 0x4007 closed 1 month ago
Noticed this here https://github.com/0x4007/typescript-action/pull/3/files#diff-e300da0383d00d275266a83902a2aff8c7f62da696de4bc47ca5810e69c01ffeR9
The context is that I am building a brand new plugin template, and I started by:
- Using GitHub's official "TypeScript Action Starter Template"
- Pulling in our ts-template
- Finally pulling in our plugin-template
Is this required?
TLDR: This PR should be closed.
I don't think permissions: write-all
is required.
Check knip-reporter.yml from the https://github.com/ubiquity/pay.ubq.fi repository which works fine without permissions: write-all
.
Update: Yes, permissions: write-all
is not required. By default knip-reporter.yml runs in a privileged context because of on: workflow_run
. Here github token of the github-actions app is passed which by default has read/write
permission for all of the scopes.
Noticed this here https://github.com/0x4007/typescript-action/pull/3/files#diff-e300da0383d00d275266a83902a2aff8c7f62da696de4bc47ca5810e69c01ffeR9
The context is that I am building a brand new plugin template, and I started by:
Is this required?