Closed 0x4007 closed 1 month ago
I got annotations working on the files view but I can't get the line targeting to be accurate.
Currently matches any instance of ""
but with regex can do more precise targeting (in the future if necessary) i.e. look for const
or let
in the same line to identify variable initializations, which is the primary suspect.
Will leave it looser targeting for now.
@0x4007 It seems you merged this with empty strings: https://github.com/ubiquity/ts-template/actions/runs/11245674853/job/31266132517 could this be fixed?
It's a warning not an error. This expresses that the reviewers should be cautious and review its context. It should never warn for the same string again because it is designed only to check the pull diff.
To be fair this probably would work by using \"\"
but I think this is not a problem anymore to worry about.
Also I just realized that it doesn't display annotations on GitHub mobile which is extremely unfortunate. At least the CI should clearly indicate a failure.
Resolves https://github.com/ubiquity/ts-template/issues/31
Currently matches any instance of
""
but with regex can do more precise targeting (in the future if necessary) i.e. look forconst
orlet
in the same line to identify variable initializations, which is the primary suspect.Will leave it looser targeting for now as an open experiment to take note of other specific scenarios to focus on later