ubiquity / ts-template

A template repository for all @ubiquity projects.
2 stars 24 forks source link

Chore/test empty string 2 #66

Closed 0x4007 closed 1 month ago

0x4007 commented 1 month ago

Resolves https://github.com/ubiquity/ts-template/issues/31

Currently matches any instance of "" but with regex can do more precise targeting (in the future if necessary) i.e. look for const or let in the same line to identify variable initializations, which is the primary suspect.

Will leave it looser targeting for now as an open experiment to take note of other specific scenarios to focus on later

ubiquity-os-deployer[bot] commented 1 month ago
19b73b2
19b73b2
57077f6
57077f6
b003b80
b003b80
e4a3ef1
e4a3ef1
61261e4
61261e4
7a35f74
7a35f74
a9b93e5
a9b93e5
1f2e6d4
1f2e6d4
bbfb46f
bbfb46f
e7149c3
e7149c3
1f2e6d4
1f2e6d4
e7149c3
e7149c3
d7312bf
d7312bf
cdc89ca
ea798ab
ea798ab
9e2370b
9e2370b
e956bec
e956bec
0deed0e
0x4007 commented 1 month ago

I got annotations working on the files view but I can't get the line targeting to be accurate.

0x4007 commented 1 month ago

Currently matches any instance of "" but with regex can do more precise targeting (in the future if necessary) i.e. look for const or let in the same line to identify variable initializations, which is the primary suspect.

Will leave it looser targeting for now.

gentlementlegen commented 1 month ago

@0x4007 It seems you merged this with empty strings: https://github.com/ubiquity/ts-template/actions/runs/11245674853/job/31266132517 could this be fixed?

0x4007 commented 1 month ago

It's a warning not an error. This expresses that the reviewers should be cautious and review its context. It should never warn for the same string again because it is designed only to check the pull diff.

To be fair this probably would work by using \"\" but I think this is not a problem anymore to worry about.

0x4007 commented 1 month ago

Also I just realized that it doesn't display annotations on GitHub mobile which is extremely unfortunate. At least the CI should clearly indicate a failure.