ubiquity / ts-template

A template repository for all @ubiquity projects.
2 stars 24 forks source link

`Empty String Check` workflow: exclude files #82

Open rndquu opened 2 days ago

rndquu commented 2 days ago

Check this failing Empty String Check workflow. It fails because there're empty strings in the following places:

So there are legit cases when empty strings can be used.

What should be done:

Keyrxng commented 23 hours ago

The run is failing due to permission reasons @rndquu, this can be closed as not planned probs.

POST /repos/ubiquity-os/ubiquity-os-plugin-installer/check-runs - 403 with id 1B40:4890C:25FDE3:2654FA:673C973B in 159ms Error: An error occurred: Resource not accessible by integration - https://docs.github.com/rest/checks/runs#create-a-check-run

rndquu commented 23 hours ago

The run is failing due to permission reasons @rndquu, this can be closed as not planned probs.

POST /repos/ubiquity-os/ubiquity-os-plugin-installer/check-runs - 403 with id 1B40:4890C:25FDE3:2654FA:673C973B in 159ms Error: An error occurred: Resource not accessible by integration - https://docs.github.com/rest/checks/runs#create-a-check-run

There're still empty string warnings so the CI would fail anyway

Keyrxng commented 23 hours ago

https://github.com/ubiquity/ts-template/blob/7b94011f7e080380dd5517db6a0b80ec6d5ae965/.github/empty-string-checker.ts#L55

You are right, my mistake, the original vision for it was that it would only present a diff warning but not crash CI so it would always succeed essentially but the diff would have it's comments