search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 61 forks source link

Parse permit URL #526

Open rndquu opened 1 year ago

rndquu commented 1 year ago

Right now here we use a plain string comparison to check that the comment is a permit URL. This approach is brittle.

We should parse URL with URLSearchParams in order to not rely on query parameters order.

KaffinPX commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Deadline Mon, 17 Jul 2023 21:56:53 GMT
Registered Wallet Please set your wallet address to use `/wallet 0x4FDE...BA18`
Payment Multiplier 1.00
Multiplier Reason undefined
Total Bounty 12.5 USD

Tips:

KaffinPX commented 1 year ago

/unassign

ubiquibot[bot] commented 1 year ago

You have been unassigned from the bounty @KaffinPX

kamaalsultan commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Deadline Mon, 31 Jul 2023 18:05:26 GMT
Registered Wallet 0xeFeF11577Db8f882F6Bf92F46008170Ba3602D40
Payment Multiplier 1.00
Multiplier Reason
Total Bounty 18.75 USD

Tips:

kamaalsultan commented 1 year ago

/unassign

ubiquibot[bot] commented 1 year ago

You have been unassigned from the bounty @ByteBallet

0x4007 commented 1 year ago

@rndquu can you verify the example link is a permalink? Looks like the lines have been shifted around and the example is no longer clear, which is why nobody is taking this up I assume.

rndquu commented 1 year ago

@rndquu can you verify the example link is a permalink? Looks like the lines have been shifted around and the example is no longer clear, which is why nobody is taking this up I assume.

fixed

Sadaf-A commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Deadline Sun, 06 Aug 2023 12:11:41 GMT
Registered Wallet Please set your wallet address to use `/wallet 0x0000...0000`
Payment Multiplier 1.00
Multiplier Reason undefined
Total Bounty 18.75 USD

Tips:

ubiquibot[bot] commented 1 year ago

Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Aug 09 2023 20:05:23 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@Sadaf-A - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Wed Aug 09 2023 20:05:23 GMT+0000 (Coordinated Universal Time)

Sadaf-A commented 1 year ago

/start

rndquu commented 1 year ago

/assign

Pls try the /start command

0x4007 commented 1 year ago

/assign

Pls try the /start command

I'm considering making a script to edit all the old comments that say /assign to make them say /start

0x4007 commented 1 year ago

/assign

Pls try the /start command

I'm considering making a script to edit all the old comments that say /assign to make them say /start

Executed it on ubiquity-dollar and ubiquibot

BeanieMen commented 1 year ago

@pavlovcik this issues isnt already done? ref

rndquu commented 1 year ago

@pavlovcik this issues isnt already done? ref

The issue is still relevant

Sadaf-A commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Deadline Fri, 08 Sep 2023 01:12:08 UTC
Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tips:

ubiquibot[bot] commented 1 year ago

Task Assignee Reward

[ CLAIM 18.75 WXDAI ]

0x0BEd00438...Af147C7025

If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!
We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

ubiquibot[bot] commented 1 year ago

Task Creator Reward

rndquu: [ CLAIM 22.8 WXDAI ]

ubiquibot[bot] commented 12 months ago

@Sadaf-A - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Fri Sep 08 2023 00:11:55 GMT+0000 (Coordinated Universal Time)

0x4007 commented 12 months ago

This was not implemented according to the specification

ubiquibot[bot] commented 12 months ago

@Sadaf-A please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 18.75 WXDAI will be deducted from your next bounty.

Sadaf-A commented 12 months ago

This was not implemented according to the specification

hey, @pavlovcik  I'd be happy to pick it up again but my max assigned limit is reached. There was some disagreement on how this change should be handled and it was changed to RegEx from URLParser midway. So, what can be done? can you assign this issue to me?

ubiquibot[bot] commented 12 months ago

@Sadaf-A The time limit for this bounty is on Sat, 23 Sep 2023 16:37:38 UTC

BeanieMen commented 12 months ago

oops

ubiquibot[bot] commented 11 months ago

Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Fri Sep 29 2023 09:37:28 GMT+0000 (Coordinated Universal Time)

Sadaf-A commented 11 months ago

Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Fri Sep 29 2023 09:37:28 GMT+0000 (Coordinated Universal Time)

the pr is still in review

ubiquibot[bot] commented 11 months ago

Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Thu Oct 05 2023 16:37:09 GMT+0000 (Coordinated Universal Time)

Sadaf-A commented 11 months ago

/start

ubiquibot[bot] commented 11 months ago

Skipping /start because it is disabled on this repo

Sadaf-A commented 11 months ago

@pavlovcik I have a open PR which will resolve this issue. could you please assign this to me. also why is the /start command not working for me?