Use Github IDs instead of names in DB

whilefoo commented 1 year ago

Currently user, repository, organization are all stored by their name in the database. User, repo or organization can change their name and I guess this is not that common but I still think it would be better to store IDs that we get from the Github API instead of names.

[ ] Store and use user ID.
[ ] Store and save username.
[ ] Ensure that user name is updated every time user ID is accessed, in case a username is updated.

0x4007 commented 1 year ago

I agree that ID makes more sense for this reason. For convenience we should still also keep at least the original username.

Sadaf-A commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Skipping /assign since no time labels are set to calculate the timeline

Sadaf-A commented 1 year ago

@pavlovcik Hey, I wanted to pick this up!

Sadaf-A commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Skipping /assign since no time labels are set to calculate the timeline

ubiquibot[bot] commented 1 year ago

@Sadaf-A The time limit for this bounty is on Mon, 07 Aug 2023 00:53:52 GMT

Sadaf-A commented 1 year ago

@whilefoo could you please elaborate a little and if possible, link the GitHub file also.

whilefoo commented 1 year ago

@pavlovcik I'm not sure how we can keep backwards compatibility. For issues and users it doesn't matter that much because we just insert them into DB and never query them, but we query other tables so things won't work because old records won't have IDs.

I guess one way would be to first add IDs to the database and fill new records with both name and ID but still query by name. Then we create a script that will update all missing IDs and once we have everything we switch to querying by ID.

0x4007 commented 1 year ago

Yeah I think we could even delete the old users to force re-registration. No big deal.

Sadaf-A commented 1 year ago

/unassign

ubiquibot[bot] commented 1 year ago

You have been unassigned from the bounty @Sadaf-A

baibhavKumar1 commented 1 year ago

@pavlovcik , here it is required to a "id" along with other details, right? Any additional changes? Thank You

ubiquibot[bot] commented 1 year ago

Available commands


- /start: Assign the origin sender to the issue automatically.
- /stop: Unassign the origin sender from the issue automatically.
- /help: List all available commands.
- /query: Comments the users multiplier and address
- /multiplier: Set the bounty payout multiplier for a specific contributor, and provide the reason for why. 
  example usage: "/wallet @user 0.5 'Multiplier reason'"
- /allow: Set access control. (Admin Only)
- /wallet: <WALLET_ADDRESS | ENS_NAME>: Register the hunter's wallet address. 
  ex1: /wallet 0x0000000000000000000000000000000000000000
  ex2: /wallet vitalik.eth

@Wholesomebruh

0x4007 commented 1 year ago

@pavlovcik , here it is required to a "id" along with other details, right? Any additional changes? Thank You

I think all the relevant context is inside of this conversation but @whilefoo any remarks?

0x4007 commented 1 year ago

My remarks

https://github.com/ubiquity/ubiquibot/issues/623

ubiquibot[bot] commented 1 year ago

These linked pull requests are closed: #618

kamaalsultan commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago

Too many assigned issues, you have reached your max of 2

ubiquibot[bot] commented 1 year ago

@byteballet The time limit for this bounty is on Fri, 18 Aug 2023 22:47:26 UTC

kamaalsultan commented 1 year ago

I agree that ID makes more sense for this reason. For convenience we should still also keep at least the original username.

Would it be good to store both name and id for repo and user or only id?

whilefoo commented 1 year ago

Would it be good to store both name and id for repo and user or only id?

Yes, I think both is good

0x4007 commented 1 year ago

Is it straightforward to update the name if a change is detected?

Otherwise it might be good to express (by the column header) that the name was a snapshot of when they first registered (this is not preferred)

kamaalsultan commented 1 year ago

Is it straightforward to update the name if a change is detected?

I don't think it's straightforward but it's absolutely doable. I am not sure if it will be still needed to add id when the name is updated whenever a change is detected.

whilefoo commented 1 year ago

I don't think it's straightforward but it's absolutely doable.

How would you detect name change without storing ID? The only option I see is when the user comments we get his ID and username and then we can check in the database if user with this ID still has the same username otherwise we update it.

ubiquibot[bot] commented 1 year ago

Do you have any updates @byteballet? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sat Aug 26 2023 00:38:42 GMT+0000 (Coordinated Universal Time)

kamaalsultan commented 1 year ago

Waiting for review. https://github.com/ubiquity/ubiquibot/pull/656

ubiquibot[bot] commented 1 year ago

Do you have any updates @byteballet? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Aug 30 2023 07:09:58 GMT+0000 (Coordinated Universal Time)

kamaalsultan commented 1 year ago

Still waiting for review.

kamaalsultan commented 1 year ago

Still waiting for review.

Want to move to another issue because it's been a while for waiting for review...

kamaalsultan commented 1 year ago

/stop

ubiquibot[bot] commented 1 year ago

These linked pull requests are closed: #656

ubiquibot[bot] commented 1 year ago

You have been unassigned from the bounty @byteballet

ubiquibot[bot] commented 1 year ago

@byteballet The time limit for this bounty is on Tue, 05 Sep 2023 11:49:07 UTC

rndquu commented 1 year ago

Still waiting for review.

Want to move to another issue because it's been a while for waiting for review...

Assigned you back :) Next time (when you hit the assignment limit) you don't need to unassign yourself from some old issue in order to take a new bounty. Just post a comment (under the issue you want to take) that you want to take a new issue but all your other PRs are under review and somebody from the core team will assign you.

ubiquibot[bot] commented 1 year ago

Do you have any updates @byteballet? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Tue Sep 05 2023 07:55:40 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@byteballet - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Tue Sep 05 2023 07:55:40 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@byteballet The time limit for this bounty is on Tue, 12 Sep 2023 10:58:03 UTC

ubiquibot[bot] commented 1 year ago

@byteballet - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Tue Sep 05 2023 07:55:40 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@byteballet - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Tue Sep 05 2023 07:55:40 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 11 months ago

@pavlovcik The time limit for this bounty is on Thu, 19 Oct 2023 06:45:20 UTC

ubiquibot[bot] commented 11 months ago

@pavlovcik - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Mon Aug 21 2023 23:05:54 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 11 months ago

@pavlovcik The time limit for this bounty is on Thu, 19 Oct 2023 06:45:42 UTC

ubiquibot[bot] commented 7 months ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 7 months ago

@pavlovcik the deadline is at 2024-02-17T12:34:56.988Z

ubiquibot[bot] commented 7 months ago

+ Evaluating results. Please wait...

ubiquibot[bot] commented 7 months ago

[ 194.3 WXDAI ]

@pavlovcik

Contributions Overview

View	Contribution	Count	Reward
Issue	Task	1.00	50
Issue	Comment	5	0
Issue	Comment	5	10.1
Review	Comment	16	67.1
Review	Comment	16	67.1

Conversation Incentives

Comment	Formatting	Relevance	Reward
I agree that ID makes more sense for this reason. For convenienc...	-	0.79	-
Yeah I think we could even delete the old users to force re-regi...	-	0.54	-
> @pavlovcik , here it is required to a "id" along with other de...	-	0.52	-
My remarks https://github.com/ubiquity/ubiquibot/issues/623...	-	0.65	-
Is it straightforward to update the name if a change is detected...	-	0.6	-
I agree that ID makes more sense for this reason. For convenienc...	2.2	0.79	2.2
Yeah I think we could even delete the old users to force re-regi...	1.7	0.54	1.7
> @pavlovcik , here it is required to a "id" along with other de...	1.5	0.52	1.5
My remarks https://github.com/ubiquity/ubiquibot/issues/623...	0.9	0.65	0.9
Is it straightforward to update the name if a change is detected...	3.8	0.6	3.8
> > I just updated the specification, but I don't see a mechanis...	1.5	-	1.5
I figured caching the username for reads is useful to save on u...	9	-	9
> I took a quick look and we never query username from database....	1.1	-	1.1
This should have merged this in weeks ago. The number of outstan...	9.1	-	9.1
@0xcodercrane In this case you should consider just regenerating...	3.8	-	3.8
Don't think it matters the order regarding conflicts but technic...	1.9	-	1.9
Will need to e2e test and merge...	0.7	-	0.7
Review comments at https://github.com/ubiquity/ubiquibot/pull/84...	1	-	1
There are many dimensions of your proposal to consider so it's h...	8.4	-	8.4
This should work on personal accounts (not just organizations) a...	2.4	-	2.4
Notes to self on incentive calculation architecture: - work bac...	4.8 li: count: 2 score: "2" words: 21	-	4.8
I think next week. It feels really close to being done but I'm a...	2.8	-	2.8
@wannacfuture its better that you branch from here instead of pu...	1.9	-	1.9
> I'm trying to use the new version with workflow dispatcher and...	8.5 code: count: 1 score: "1" words: 26	-	8.5
You guys should make sure you're using the same version of Node....	9.2	-	9.2
@gitcoindev maybe you can help fix the knip CI here...	1	-	1
> > I just updated the specification, but I don't see a mechanis...	1.5	-	1.5
I figured caching the username for reads is useful to save on u...	9	-	9
> I took a quick look and we never query username from database....	1.1	-	1.1
This should have merged this in weeks ago. The number of outstan...	9.1	-	9.1
@0xcodercrane In this case you should consider just regenerating...	3.8	-	3.8
Don't think it matters the order regarding conflicts but technic...	1.9	-	1.9
Will need to e2e test and merge...	0.7	-	0.7
Review comments at https://github.com/ubiquity/ubiquibot/pull/84...	1	-	1
There are many dimensions of your proposal to consider so it's h...	8.4	-	8.4
This should work on personal accounts (not just organizations) a...	2.4	-	2.4
Notes to self on incentive calculation architecture: - work bac...	4.8 li: count: 2 score: "2" words: 21	-	4.8
I think next week. It feels really close to being done but I'm a...	2.8	-	2.8
@wannacfuture its better that you branch from here instead of pu...	1.9	-	1.9
> I'm trying to use the new version with workflow dispatcher and...	8.5 code: count: 1 score: "1" words: 26	-	8.5
You guys should make sure you're using the same version of Node....	9.2	-	9.2
@gitcoindev maybe you can help fix the knip CI here...	1	-	1

[ 0 WXDAI ]

@BeanieMen

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	0

Conversation Incentives

Comment	Formatting	Relevance	Reward
🎉...	-	-	-

[ 52.6 WXDAI ]

@gitcoindev

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	7	52.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
> There also seems to be an issue with ubiquibot-logger > > `...	9.1 code: count: 4 score: "4" words: 4	-	9.1
> > Hi @whilefoo , the `ubiquibot-logger` is an ESM module https...	7.3 code: count: 5 score: "5" words: 7	-	7.3
> > > Hi @whilefoo , the `ubiquibot-logger` is an ESM module htt...	14.9 code: count: 7 score: "7" words: 10	-	14.9
hi @whilefoo I will give this priority and try to fix till Monda...	1.4	-	1.4
@whilefoo I am on v0.3.4 already, so far no luck but closer and ...	5.2	-	5.2
hi @whilefoo could you please check ubiquibot-logger v0.3.5 ? I...	8.9 code: count: 1 score: "1" words: 6	-	8.9
Btw, about @pavlovcik 's last comment, I agree that we should sy...	5.8	-	5.8

[ 1.1 WXDAI ]

@Draeieg

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	1.1

Conversation Incentives

Comment	Formatting	Relevance	Reward
let me know when this is ready to go into QA...	1.1	-	1.1

[ 17.1 WXDAI ]

@kamaalsultan

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	5	8.2
Review	Comment	4	8.9

Conversation Incentives

Comment	Formatting	Relevance	Reward
> I agree that ID makes more sense for this reason. For convenie...	1.7	0.6	1.7
> Is it straightforward to update the name if a change is detect...	3.5	0.58	3.5
Waiting for review. https://github.com/ubiquity/ubiquibot/pull/...	1	0.4	1
Still waiting for review....	0.4	0.32	0.4
> Still waiting for review. Want to move to another issue bec...	1.6	0.35	1.6
> I just updated the specification, but I don't see a mechanism ...	1.2	-	1.2
> That might have made sense actually. Hopefully it's fine I upd...	6.5	-	6.5
> Looks like we should get rid of the username entirely then. ...	0.6	-	0.6
> let me know when this is ready to go into QA I guess it's n...	0.6	-	0.6

[ 1.6 WXDAI ]

@0xcodercrane

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	1.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
should I merge https://github.com/ubiquity/ubiquibot/pull/643 in...	1.6	-	1.6

[ 0.6 WXDAI ]

@wannacfuture

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	1	0.6

Conversation Incentives

Comment	Formatting	Relevance	Reward
should I resolve the conflicts? @pavlovcik ...	0.6	-	0.6

[ 2.3 WXDAI ]

@Sadaf-A

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	2	2.3

Conversation Incentives

Comment	Formatting	Relevance	Reward
@pavlovcik Hey, I wanted to pick this up!...	0.8	0.36	0.8
@whilefoo could you please elaborate a little and if possible, l...	1.5	0.58	1.5

[ 154.5 WXDAI ]

@rndquu

Contributions Overview

View	Contribution	Count	Reward
Issue	Comment	1	6.5
Review	Comment	5	148

Conversation Incentives

Comment	Formatting	Relevance	Reward
> > Still waiting for review. > > Want to move to another iss...	6.5	0.21	6.5
> I figured caching the username for reads is useful to save on ...	6.6 a: count: 1 score: "1" words: 2 code: count: 1 score: "1" words: 1	-	6.6
@byteballet Could you resolve the conflicts one more time? @w...	1.7	-	1.7
@pavlovcik There is the supabase [diff tool](https://supabas...	42.1 a: count: 4 score: "4" words: 7 li: count: 7 score: "7" words: 110 code: count: 10 score: "10" words: 11	-	42.1
@pavlovcik Regarding the `locations` and metadata. This i...	96 h2: count: 2 score: "2" words: 11 h3: count: 4 score: "4" words: 4 a: count: 2 score: "2" words: 3 li: count: 10 score: "10" words: 170 code: count: 21 score: "21" words: 67 td: count: 16 score: "16" words: 57	-	96
> Alternatively we do the two API calls but there's a good chanc...	1.6	-	1.6

[ 105.4 WXDAI ]

@whilefoo

Contributions Overview

View	Contribution	Count	Reward
Issue	Specification	1	19.4
Issue	Comment	3	30.2
Review	Comment	6	55.8

Conversation Incentives

Comment	Formatting	Relevance	Reward
Currently user, repository, organization are all stored by their...	19.4 li: count: 3 score: "3" words: 27 hr: count: 1 score: "1" words: 0	1	19.4
@pavlovcik I'm not sure how we can keep backwards compatibility....	19.6	0.89	19.6
> Would it be good to store both name and id for repo and user o...	1.2	0.56	1.2
> I don't think it's straightforward but it's absolutely doable....	9.4	0.47	9.4
I took a quick look and we never query username from database. M...	5	-	5
I'm trying to use the new version with workflow dispatcher and I...	13.6 code: count: 1 score: "2" words: 26	-	13.6
There also seems to be an issue with ubiquibot-logger ``` co...	15.8 code: count: 1 score: "2" words: 0	-	15.8
> Hi @whilefoo , the `ubiquibot-logger` is an ESM module https:/...	17.8 code: count: 5 score: "10" words: 7	-	17.8
> Following the article https://dev.to/tigawanna/building-and-pu...	2.4	-	2.4
@gitcoindev it's working now, thanks!...	1.2	-	1.2

[ 3.7 WXDAI ]

@EtherealGlow

Contributions Overview

View	Contribution	Count	Reward
Review	Comment	5	3.7

Conversation Incentives

Comment	Formatting	Relevance	Reward
I pray for the refactor to be done quickly 🙏...	0.9	-	0.9
Do you guys have any estimate on when the refactor will be done ...	1.3	-	1.3
Any new estimate for how much time is left?...	0.9	-	0.9
🙏...	-	-	-
When will the refactor be done 😭...	0.6	-	0.6

ubiquity / ubiquibot