ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

feat: price overide #735

Closed BeanieMen closed 11 months ago

BeanieMen commented 1 year ago

Resolves #128

netlify[bot] commented 1 year ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit 2492c91260bc24766103e4060187fd20e8da4fb2
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/651b6e617d433b0008dea0a8
Deploy Preview https://deploy-preview-735--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

BeanieMen commented 1 year ago

@rndquu this might work

0x4007 commented 1 year ago

You need to post working examples of the expected results from your bot

BeanieMen commented 1 year ago

I can't qa this is tried but I am getting Error logging to supabase: undefined and a whole bunch of others

BeanieMen commented 1 year ago

@pavlovcik do you know any fixes for this?

0x4007 commented 1 year ago

@ubiquity/software-development rfc

wannacfuture commented 1 year ago

Check if you have set supabase - related env variables. Also, even it is saying like that, there will be no problem for the bot to act.

You can just ignore supabase loggin related errors. @me505

BeanieMen commented 1 year ago

I have set the supabase url and key

BeanieMen commented 1 year ago

in the issue i mentioned nothings seems to work

whilefoo commented 1 year ago

I can't qa this is tried but I am getting Error logging to supabase: undefined and a whole bunch of others

make sure you run all migrations (https://github.com/ubiquity/ubiquibot/tree/development/supabase) yarn supabase db push

BeanieMen commented 12 months ago

first is the oldest last is the newest kinda like a stack

BeanieMen commented 12 months ago

gotta fix that

BeanieMen commented 12 months ago

https://github.com/me505/ubiquibot/issues/6

BeanieMen commented 12 months ago

@whilefoo heres the qa

BeanieMen commented 12 months ago

https://github.com/me505/ubiquibot/issues/6

BeanieMen commented 12 months ago

it generates correct permit now

BeanieMen commented 11 months ago

for such small things the bot should automatically use yarn lint --fix or somethig

BeanieMen commented 11 months ago

@whilefoo cant qa because of Error: Cannot find module './lib/src/index.js' from '/workspaces/ubiquibot'

BeanieMen commented 11 months ago

i tried yarn clean and then reinstall and start, didnt work

whilefoo commented 11 months ago

@whilefoo cant qa because of Error: Cannot find module './lib/src/index.js' from '/workspaces/ubiquibot'

yes this is a known bug that's getting fixed. in the mean time you can change to

"start": "probot run ./lib/index.js",

in your package.json

0x4007 commented 11 months ago

Where's the proof that it works

BeanieMen commented 11 months ago

why does the bot hate me

BeanieMen commented 11 months ago
[Error: ENOENT: no such file or directory, open '/workspaces/ubiquibot/lib/assets/images/pmg.png'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/workspaces/ubiquibot/lib/assets/images/pmg.png'
}
error Command failed with exit code 1.
BeanieMen commented 11 months ago

theres no pmg.png in src/assets/images so i cant even jinx it

whilefoo commented 11 months ago

do this:

mkdir lib/assets/images
cp src/assets/images/flat.png lib/assets/images/
0xcodercrane commented 11 months ago

TLDR about the image path issue.

We have been keeping the codebase for a long time which would not work with the lambda function in the telegram weekly post feature. If it's so panic to you @me505, you can comment it out and let me know if its being included in the merge into the development branch.

BeanieMen commented 11 months ago

@pavlovcik it prob can generate the permit for 25 usd not 400 as that whole thing wasnt modified

BeanieMen commented 11 months ago

@pavlovcik its generating correct amount now

BeanieMen commented 11 months ago

When will this get reviewed

wannacfuture commented 11 months ago

https://github.com/ubiquity/ubiquibot/pull/735#issuecomment-1736518788

Hey @me505 What about this?

BeanieMen commented 11 months ago

I haven't commented anything out