ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

Parse Permit Url #738

Closed Sadaf-A closed 12 months ago

Sadaf-A commented 1 year ago

Resolves #526

netlify[bot] commented 1 year ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit b23de34480157bb5ed2cb40895f91db4960d4714
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/6507ed2914164700089f5732
Deploy Preview https://deploy-preview-738--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

whilefoo commented 12 months ago

the parsing should be done with URLSearchParams to avoid dependence on param order like @Sadaf-A did. I don't understand why you changed it to regex

Sadaf-A commented 12 months ago

the parsing should be done with URLSearchParams to avoid dependence on param order like @Sadaf-A did. I don't understand why you changed it to regex

@whilefoo @0xcodercrane made those changes so I didn't wanna make any more changes i fixed the errors that arised after it earlier i was also using URLSearchParams as requested by you

whilefoo commented 12 months ago

@whilefoo @0xcodercrane made those changes so I didn't wanna make any more changes i fixed the errors that arised after it earlier i was also using URLSearchParams as requested by you

yes I know @0xcodercrane made those changes

0xcodercrane commented 11 months ago

We don't create a complex claim URL here, so I guess no need to worry about the param order.

In upper lines, we were also using regex so wanted to make the parse consistent.

If the order problem happens, lets update it at that time.

0x4007 commented 11 months ago

This isn't the spec

Sadaf-A commented 11 months ago

the parsing should be done with URLSearchParams to avoid dependence on param order like @Sadaf-A did. I don't understand why you changed it to regex

@whilefoo @pavlovcik should i open another PR for this?