feat: add repo specific wallet support - Githubissues

ubiquity / ubiquibot

Putting the 'A' in 'DAO'

https://github.com/marketplace/ubiquibot

MIT License

17 stars 60 forks source link

feat: add repo specific wallet support #747

Closed BeanieMen closed 11 months ago

BeanieMen commented 1 year ago

Resolves #719

netlify[bot] commented 1 year ago

Deploy Preview for ubiquibot-staging ready!

Name	Link
Latest commit	d7d181fe87fa63f4f51c8f2d77c073cb93765847
Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/650817df76cbdb0008c42264
Deploy Preview	https://deploy-preview-747--ubiquibot-staging.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0x4007 commented 1 year ago

Please demo this working by configuring your test org and showing a repo specific permit and a generic org permit.

BeanieMen commented 1 year ago

do i have to remove merged configs or no, i dont really get why not if no

BeanieMen commented 12 months ago

@pavlovcik https://github.com/me505/ubiquibot/issues/5

BeanieMen commented 12 months ago

https://github.com/me505/ubiquibot/blob/development/.github/ubiquibot-config.yml

BeanieMen commented 12 months ago

the failed attempts were because i was dumb while trying to generate a key

BeanieMen commented 12 months ago

Should I only modify wide repo config?

BeanieMen commented 12 months ago

@whilefoo done

BeanieMen commented 12 months ago

@whilefoo how to setup org wallet

whilefoo commented 12 months ago

@whilefoo how to setup org wallet

it's private-key-encrypted field in org and repo config. you can generate a random one

BeanieMen commented 12 months ago

https://github.com/me505/ubiquibot/issues/7 for repo wallet

BeanieMen commented 12 months ago

https://github.com/me505-qa/ubiquibot/issues/1 org permit

BeanieMen commented 12 months ago

@whilefoo idk how to prove it to you that this is a org permit but this is it

BeanieMen commented 12 months ago

What do you want me for?

BeanieMen commented 12 months ago

@pavlovcik can you review this?

0xcodercrane commented 11 months ago

What do you want me for?

oh sorry my bad. I wanted to tag whilefoo lol

0x4007 commented 11 months ago

Can you guys verify the following scenarios hold true with this implementation?

The org sets an org wallet; no repo wallet set; payouts generated from org wallet.
The org sets an org wallet; repo wallet set; payouts generated from repo wallet.

whilefoo commented 11 months ago

Can you guys verify the following scenarios hold true with this implementation?

The org sets an org wallet; no repo wallet set; payouts generated from org wallet.

The org sets an org wallet; repo wallet set; payouts generated from repo wallet.

I just tested and can confirm