search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

fix: use bot penalty #749

Closed Keyrxng closed 12 months ago

Keyrxng commented 1 year ago

Checks if the bot penalty comment created at is more than last activity, if so it returns only the delivery timeline else it will unnassign.

Resolves https://github.com/ubiquity/ubiquibot/issues/681

Example https://github.com/Keyrxng/UbiquityBotTesting/issues/11#issuecomment-1712968225

For testing purposes I added the penalty comment myself to workaround not having setup the backend fully yet but I believe it shows the logic working as intended.

My issue is old enough that it was unassigning me as you'll see with the bot doing so in the interaction list above the comments, after the fix it no longer unassigns.

netlify[bot] commented 1 year ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit bf489c23b4539e25247f71594537d36bdf3cad17
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/6505f4e4eb846900084d7d2f
Deploy Preview https://deploy-preview-749--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0x4007 commented 1 year ago

I believe that it makes a lot more sense to check the timestamp of when it was reopened, instead of the follow up comment.

Why did you target the follow up comment?

Keyrxng commented 1 year ago

I think this issue's purpose is to make bot to not unassign hunter right after manual assigning.

I can't see it on your QA, @Keyrxng Would you mind posting a valid one?

Or we can do it in a more simple way. https://github.com/ubiquity/ubiquibot/pull/759/files @pavlovcik , @0xcodercrane

I had read the issue as the bot unassigning once an old issue has been reopened which forced the bot to unassign due to it being over the deliverable date, the manual assign being automatically unassigned thing is just a by-product of this.

After my impl the bot stopped trying to unassign me after I manually reassigned.

But by all means if your linked pr solves this issue then you take it

0xcodercrane commented 1 year ago

I think this issue's purpose is to make bot to not unassign hunter right after manual assigning.

I can't see it on your QA, @Keyrxng Would you mind posting a valid one?

Or we can do it in a more simple way. https://github.com/ubiquity/ubiquibot/pull/759/files @pavlovcik , @0xcodercrane

The purpose is to reset the deadline when you reopen the closed issue + stop unassigning the hunter at that time.

0xcodercrane commented 1 year ago

took a look at your PR for this task. It would also work for this issue but you have been solving another issue. @wannacfuture.

To complete the issue: 1/ Would you @Keyrxng bring up @wannacfuture 's codebase into your branch? It looks better to me. 2/ The assignee should still be @Keyrxng.

wannacfuture commented 1 year ago

took a look at your PR for this task. It would also work for this issue but you have been solving another issue. @wannacfuture.

the root cause of the PR's related issue also contains fixing deadline.

Keyrxng commented 1 year ago

2/ The assignee should still be Keyrxng.

This feels sort of wrong, you wanna at least split it @wannacfuture?

wannacfuture commented 1 year ago

2/ The assignee should still be Keyrxng.

This feels sort of wrong, you wanna at least split it @wannacfuture?

Just take it. @Keyrxng. I can think as hotfix as the responsibility for core team member. no problem.

Keyrxng commented 1 year ago

Humbled mate, I appreciate it

0xcodercrane commented 12 months ago

Thank you guys for the great swarming lol

Please re-request a review from me once done. @Keyrxng