search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

Config Name Format #750

Closed Sadaf-A closed 1 year ago

Sadaf-A commented 1 year ago

Resolves #711

netlify[bot] commented 1 year ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit 4c666eb2a5ac7d810bebb93d4a9adee3b7ae4ca3
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/650058a71a1c9c0008d49012
Deploy Preview https://deploy-preview-750--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sadaf-A commented 1 year ago

A couple of stuff I don't understand in the PRs.

1/ Why do we change even workflow filenames? Is this intended action item. If I understood the origin spec correctly, it should be config-related task. please verify me @whilefoo @Sadaf-A 2/ If we change ubiquibot-config.yml to ubiquibotConfig.yml, we should also update the codebase (there is a line to read config file: ubiquibot-config.yml in the codebase).

I wasn't sure about it either I asked about it on the issue and @Wholesomebruh suggested that i open a PR and work on the requested changes.

Sadaf-A commented 1 year ago

Like @0xcodercrane said, this task is only related to the config, so you don't need to change workflows and other names. Only properties inside the config should be in camelCase.

in the config folder there are all typescript files. can you link the .yml file?

whilefoo commented 1 year ago

https://github.com/ubiquity/ubiquibot/blob/development/.github/ubiquibot-config.yml