feat: enable comment incentives on closed issues

[EtherealGlow]

Resolves #754

Quality Assurance: None for now

[netlify[bot]]

✅ Deploy Preview for ubiquibot-staging ready!

Name	Link
🔨 Latest commit	3aab392128d3e026545c6c7e6026b5156e20c6eb
🔍 Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/6517e218b676da00084a4527
😎 Deploy Preview	https://deploy-preview-762--ubiquibot-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[EtherealGlow]

i cant see anything that would stop a incentive permit from generating in post @pavlovcik

[EtherealGlow]

@0xcodercrane i cant see anything that would make a incentive permit to stop generating

[0xcodercrane]

@0xcodercrane i cant see anything that would make a incentive permit to stop generating

https://github.com/ubiquity/ubiquibot/blob/development/src/handlers/pricing/action.ts#L17

can you see this line? @EtherealGlow

[EtherealGlow]

@0xcodercrane But what about incentives tho, incentives don't have a price label

[wannacfuture]

@0xcodercrane But what about incentives tho, incentives don't have a price label

you can refer incentivizeComments and incentivizeCreatorComment functions

[EtherealGlow]

https://github.com/EtherealGlow/ubiquibot/issues/18 on this it tried generating conversation rewards. https://github.com/EtherealGlow/ubiquibot/issues/16 on this it generated conversation rewards after reopening the issue

[EtherealGlow]

@wannacfuture can you review this

[0x4007]

https://github.com/EtherealGlow/ubiquibot/issues/18 on this it tried generating conversation rewards.

https://github.com/EtherealGlow/ubiquibot/issues/16 on this it generated conversation rewards after reopening the issue

This doesn't generate rewards on the meta issue why are you submitting this as completed work?

[EtherealGlow]

man now somehow my permits are broken, @Draeieg can you help me qa this because i cannot

[EtherealGlow]

EtherealGlow#18 on this it tried generating conversation rewards. EtherealGlow#16 on this it generated conversation rewards after reopening the issue

This doesn't generate rewards on the meta issue why are you submitting this as completed work?

it was prob because all incentive elements were set to 0 my fault on that one

[whilefoo]

@EtherealGlow what's the status of this PR? If it's done, can you post QA? Also resolve the conflicts

[EtherealGlow]

Incentives aren't working even if I do getPrivateKey(cipher) directly

[EtherealGlow]

@whilefoo man i misunderstood the spec again

[EtherealGlow]

will do this shortly, fixing the bot is harder than any issue i have ever done

[EtherealGlow]

@whilefoo how would i qa, my wallet doesnt have enough balance and it refuses to generate a permit

[wannacfuture]

@whilefoo how would i qa, my wallet doesnt have enough balance and it refuses to generate a permit

@EtherealGlow Bot is able to generate permit URL even you don't have enough balance.

You cannot just claim it when you go to that url(saying insuficcient fund).

[EtherealGlow]

@whilefoo how would i qa, my wallet doesnt have enough balance and it refuses to generate a permit

@EtherealGlow Bot is able to generate permit URL even you don't have enough balance.

You cannot just claim it when you go to that url(saying insuficcient fund).

https://github.com/me505/ubiquibot/issues/10#issuecomment-1736926872

[wannacfuture]

@whilefoo how would i qa, my wallet doesnt have enough balance and it refuses to generate a permit

@EtherealGlow Bot is able to generate permit URL even you don't have enough balance. You cannot just claim it when you go to that url(saying insuficcient fund).

me505#10 (comment)

Please take a closer look at the generatePermitForComments function. @me505 I don't think its releated to the funds in your wallet. There is no feature to check the funds in the wallet in that function.

The reason of that error message is not your insufficient funds in your wallet. I bet it is related to missing account or the reward value is 0 or higher than maxPermitPrice.

[EtherealGlow]

@wannacfuture any idea why the result of generatePermitForComments is undefined?

[wannacfuture]

@wannacfuture any idea why the result of generatePermitForComments is undefined?

Like I said, I'm assuming that the reward value is calculated as 0 or account or missing or is higher than the maxPermitPrice.

You can check it adding console logs to that function.