search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

Fix: renamed default config file #763

Closed baibhavKumar1 closed 12 months ago

baibhavKumar1 commented 1 year ago

Resolves #725

Quality Assurance: Passing checks

netlify[bot] commented 1 year ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit d8dba992ba32dbc8b909569573ba564e6b95812b
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/6507ec26e6580d0008fcfd8f
Deploy Preview https://deploy-preview-763--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

baibhavKumar1 commented 1 year ago

@pavlovcik @rndquu , last PR was automatically closed as GitHub suggested to remove the commit and then resolve the conflicts. No extra changes are made. Please have a look at this.

0x4007 commented 1 year ago

Generally "QA" needs evidence like links. This is a simple change though so let me inspect

0xcodercrane commented 12 months ago

The PR merge should be happening with the relevant changes in pay.ubq.fi right? @rndquu

rndquu commented 12 months ago

The PR merge should be happening with the relevant changes in pay.ubq.fi right? @rndquu

You're free to merge the current PR

There is already a related issue for onboarding refactoring

We will deploy a new version of pay.ubq.fi only when https://github.com/ubiquity/pay.ubq.fi/issues/135 is implemented so that nothing is broken

0xcodercrane commented 12 months ago

Ok let me handle the merge once the conversations resolved.

0xcodercrane commented 12 months ago

@Wholesomebruh bump for the second request:

2/ Then we should move ubiquibot-config-default.ts into the src folder to make sure it's being built/checked

baibhavKumar1 commented 12 months ago

@0xcodercrane , moved the ubiquity-config-default to src folder.

0x4007 commented 11 months ago

@0xcodercrane , moved the ubiquity-config-default to src folder.

This can break other systems, including the partner onboarding @rndquu is this all clear?

0xcodercrane commented 11 months ago

@0xcodercrane , moved the ubiquity-config-default to src folder.

This can break other systems, including the partner onboarding @rndquu is this all clear?

I don't think so

rndquu commented 11 months ago

@0xcodercrane , moved the ubiquity-config-default to src folder.

This can break other systems, including the partner onboarding @rndquu is this all clear?

I don't think so

It does break the onboarding but we already have a related issue for onboarding refactoring so we won't deploy a new version of pay.ubq.fi unless the https://github.com/ubiquity/pay.ubq.fi/issues/135 is implemented

0xcodercrane commented 11 months ago

From my understanding of my questions before merging the PR, I was free to merge right?

Ideally, we shouldn't merge the pr if it breaks something even if it is partner onboarding.

So I guess the solution here is to wrap up the related issues as soon as possible.

rndquu commented 11 months ago

From my understanding of my questions before merging the PR, I was free to merge right?

yes

So I guess the solution here is to wrap up the related issues as soon as possible

yes