ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

Penalty Improvement - Incorrect Penalty Amount #768

Open 0x4007 opened 1 year ago

0x4007 commented 1 year ago

This was my reward not @whilefoo's so this bot is confused on how much to penalize. This should be fixed. Also I checked the database and it did not update this value so I'm double confused on what just happened here. The database should definitely be updated!

@whilefoo please be sure to review this conversation and implement any necessary fixes. Unless this is closed as completed, its payment of 73.6 WXDAI will be deducted from your next bounty.

Originally posted by @ubiquibot[bot] in https://github.com/ubiquity/ubiquibot/issues/680#issuecomment-1718491622

whilefoo commented 1 year ago

It seems penalties were implemented back when there was only the assignee reward and no creator/conversation rewards so it just looks for a first claim URL. We should fix this and try to switch to comment metadata as soon as possible