search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 60 forks source link

fix: removed the 10 white space infront of the issue's text #779

Closed GaryThisSidee closed 11 months ago

GaryThisSidee commented 12 months ago

Resolves #772

netlify[bot] commented 12 months ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit 02deb96a2021c6ef6841294d44984ed3b8792854
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/65104ce42e65880008c01bc1
Deploy Preview https://deploy-preview-779--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0x4007 commented 11 months ago

Sensible defaults sounds like a good idea!

GaryThisSidee commented 11 months ago

https://github.com/ubiquity/ubiquibot/blob/628c2221a2d6ee62583b702d711ba57393415b6c/src/helpers/comment.ts#L10

you should modify this function to still parse the element but not its children. For example currently if it's ignore-children: code it won't include code item and its children, but we still want to include code. Don't forget to resolve conflicts

@pavlovcik do we want to set some sensible default like ignore-children: blockquote, code, pre, a

sure

GaryThisSidee commented 11 months ago

@whilefoo going to open a new pull req and push the changes in one commit its kinda messy rn