Closed EtherealGlow closed 10 months ago
Name | Link |
---|---|
Latest commit | 4d09c74587c9a1fe097295b7ebdf8ca422b32fad |
Latest deploy log | https://app.netlify.com/sites/ubiquibot-staging/deploys/6533b687a585a100083f9cc8 |
Deploy Preview | https://deploy-preview-783--ubiquibot-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
same logic as this https://github.com/ubiquity/ubiquibot/pull/708
just it follows up with the reviewer/reviewers now instead of doing nothing
doesnt this execute whenever the bot tries to follow up with reviewer? it only gets the reviewer which have pending reviews it doesnt get the reviewers who have already reviewed
QA should always be posted thats why its part of the pull request template.
how would i even qa this?
Just post proof that it works on your fork
how would i even qa this?
Please refer to the README.md
qa idk why the bot requested the review twice
Now that I see it's prob because it's followed up a second time, as it was like 30s to follow up and 5mins to disqualify
Please read this again. @EtherealGlow
https://github.com/ubiquity/ubiquibot/pull/783#pullrequestreview-1635004710
@wannacfuture is there something in github api which provides the timestamps for the requested reviewers
@wannacfuture is there something in github api which provides the timestamps for the requested reviewers
you can use octokit. There is createdAt field representing the timestamp or review request for certain reviewers.
I think there is already a function for that: getReviewRequests
{
"users": [
{
"login": "octocat",
"id": 1,
"node_id": "MDQ6VXNlcjE=",
"avatar_url": "https://github.com/images/error/octocat_happy.gif",
"gravatar_id": "",
"url": "https://api.github.com/users/octocat",
"html_url": "https://github.com/octocat",
"followers_url": "https://api.github.com/users/octocat/followers",
"following_url": "https://api.github.com/users/octocat/following{/other_user}",
"gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
"organizations_url": "https://api.github.com/users/octocat/orgs",
"repos_url": "https://api.github.com/users/octocat/repos",
"events_url": "https://api.github.com/users/octocat/events{/privacy}",
"received_events_url": "https://api.github.com/users/octocat/received_events",
"type": "User",
"site_admin": false
}
],
"teams": [
{
"id": 1,
"node_id": "MDQ6VGVhbTE=",
"url": "https://api.github.com/teams/1",
"html_url": "https://github.com/orgs/github/teams/justice-league",
"name": "Justice League",
"slug": "justice-league",
"description": "A great team.",
"privacy": "closed",
"notification_setting": "notifications_enabled",
"permission": "admin",
"members_url": "https://api.github.com/teams/1/members{/member}",
"repositories_url": "https://api.github.com/teams/1/repos",
"parent": null
}
]
}
In this example response I couldnt find a createdAt field
@EtherealGlow Please take a look at the link I have provided again.
/repos/{owner}/{repo}/pulls/{pull_number}/requested_reviewers
i am not following something because i think thats for requesting reviews not for getting all requested reviews i could not find a created at in this https://api.github.com/repos/EtherealGlow/ubiquibot/pulls/25/requested_reviewers
@wannacfuture your API call is to request a reviewer not listing them like @EtherealGlow said. Instead of requested reviewers API, I think we can use events API, it includes review_requested
event and has a timestamp.
Ohhh that makes it easy
i am tired of this bot 😢
UbiquiBot Error: Invalid repo config: data must NOT have additional properties. Unnecessary properties: evmNetworkId undefined error ubiquibot EtherealGlow 1761727853 25
@whilefoo i even tried this config https://github.com/rndquu-org/test-repo/blob/6613b3bf91462018d1cec1b8f09eb27d072f8fc6/.github/ubiquibot-config.yml still doesnt work
Any idea why the bot might not be working, the config is right
@EtherealGlow can you link me your config?
can you try running the bot with latest development branch and check if the issue is still present?
wait just a day or two this is almost done
uhhh what
Resolves #324
Quality Assurance: