Move shared constants to default config file.

0xcodercrane commented 11 months ago

          @0xcodercrane shouldn't these all be moved to `ubiquibot-config-default.ts` ? If so, please file a new issue or just handle it. Thanks!

_Originally posted by @pavlovcik in https://github.com/ubiquity/ubiquibot/pull/748#discussion_r1332052611_

molecula451 commented 11 months ago

/start

ubiquibot[bot] commented 11 months ago





Deadline
Fri, 22 Sep 2023 06:32:10 UTC


Registered Wallet
0x4D0704f400D57Ba93eEa88765C3FcDBD826dCFc4

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

molecula451 commented 11 months ago

so it's shared.ts being deprecated/purged? @0xcodercrane

molecula451 commented 11 months ago

Should we get rid of https://github.com/ubiquity/ubiquibot/blob/b417336356e2ad7df62aa1fcf04e1ed71f4ea87c/src/configs/shared.ts#L27

as there is an:

https://github.com/ubiquity/ubiquibot/blob/b417336356e2ad7df62aa1fcf04e1ed71f4ea87c/src/configs/ubiquibot-config-default.ts#L4

??

molecula451 commented 11 months ago

development seems broken, can't PR till it's fixed

0x4007 commented 11 months ago

You can certainly pr and rebase when it's fixed.

molecula451 commented 11 months ago

You can certainly pr and rebase when it's fixed.

https://github.com/ubiquity/ubiquibot/pull/802

0x4007 commented 11 months ago

Should we get rid of

https://github.com/ubiquity/ubiquibot/blob/b417336356e2ad7df62aa1fcf04e1ed71f4ea87c/src/configs/shared.ts#L27

as there is an:

https://github.com/ubiquity/ubiquibot/blob/b417336356e2ad7df62aa1fcf04e1ed71f4ea87c/src/configs/ubiquibot-config-default.ts#L4

??

Default I feel like it should be on Mainnet. Seems quite opinionated for us to default to a sidechain.

molecula451 commented 11 months ago

Should we get rid of https://github.com/ubiquity/ubiquibot/blob/b417336356e2ad7df62aa1fcf04e1ed71f4ea87c/src/configs/shared.ts#L27

as there is an: https://github.com/ubiquity/ubiquibot/blob/b417336356e2ad7df62aa1fcf04e1ed71f4ea87c/src/configs/ubiquibot-config-default.ts#L4

??

Default I feel like it should be on Mainnet. Seems quite opinionated for us to default to a sidechain.

and to your suprise, this constant it's not being used anywhere in the code, no but there is other code that it's being responsible for the rpc

ubiquibot[bot] commented 11 months ago

Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sat Sep 23 2023 19:19:58 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 11 months ago

Do you have any updates @molecula451? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sat Sep 23 2023 19:19:58 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 10 months ago

Task Assignee Reward

[ CLAIM 18.75 WXDAI ]

0x4D0704f40...BD826dCFc4

If you've enjoyed your experience in the DevPool, we'd appreciate your support. Follow Ubiquity on GitHub and star this repo. Your endorsement means the world to us and helps us grow!

We are excited to announce that the DevPool and UbiquiBot are now available to partners! Our ideal collaborators are globally distributed crypto-native organizations, who actively work on open source on GitHub, and excel in research & development. If you can introduce us to the repository maintainers in these types of companies, we have a special bonus in store for you!

ubiquibot[bot] commented 10 months ago

Task Creator Reward

0xcodercrane: [ CLAIM 17.4 WXDAI ]

molecula451 commented 10 months ago

it would be nice to get back commentary rewards @0xcodercrane

ubiquity / ubiquibot