fix: hotfix to local build

molecula451 commented 11 months ago

Resolves #796

Quality Assurance:

https://github.com/ubiquity/ubiquibot/issues/796#issuecomment-1730921561

latest branch development, on quick yarn build, puts index.js outside /src folder

$ probot run ./lib/index.js
INFO (probot): 
INFO (probot): Welcome to Probot!
INFO (probot): Probot is in setup mode, webhooks cannot be received and
INFO (probot): custom routes will not work until APP_ID and PRIVATE_KEY
INFO (probot): are configured in .env.
INFO (probot): Please follow the instructions at http://localhost:3000 to configure .env.
INFO (probot): Once you are done, restart the server.
INFO (probot): 
INFO (server): Running Probot v12.3.1 (Node.js: v20.6.1)
INFO (server): Forwarding https://smee.io/lIAqkpXtACUt1U10 to http://localhost:3000/
INFO (server): Listening on http://localhost:3000
INFO (server): Connected

netlify[bot] commented 11 months ago

Deploy Preview for ubiquibot-staging ready!

Name	Link
Latest commit	cd5aa992d91032b0d066d70ec340a0367e9bd74a
Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/650f565e78e4430008d095d4
Deploy Preview	https://deploy-preview-797--ubiquibot-staging.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

molecula451 commented 11 months ago

we could also make a new command start:local

molecula451 commented 11 months ago

it's possible also that https://github.com/ubiquity/ubiquibot/blob/16aaa179832c09532822ccd361be4bc07835fcc8/package.json#L17

it's copying everything including index.js back to /lib

molecula451 commented 11 months ago

https://github.com/ubiquity/ubiquibot/issues/796#issuecomment-1731268558

molecula451 commented 11 months ago

lib/assets/images

there is no such thing as lib/assets/images but

about flat.png, it gets to /src/assets/images it's there

molecula451 commented 11 months ago

lib/assets/images

there is no such thing as lib/assets/images but

about flat.png, it gets to /src/assets/images it's there

also I see you're on Node on Windows, it might be interesting to reproduce this there with a new issue

molecula451 commented 11 months ago

let's get this merge as there are tasks that requires it #291

people having this issue

Me Whilefoo Serprintour devpanther

whilefoo commented 11 months ago

there is no such thing as lib/assets/images but

about flat.png, it gets to /src/assets/images it's there

that's literally the problem. lib/assets/images should exist and flat.png should be copied in there.

also I see you're on Node on Windows, it might be interesting to reproduce this there with a new issue

I'm on MacOS. This is a problem we had before so I know it's reproducible.

molecula451 commented 11 months ago

there is no such thing as lib/assets/images but

about flat.png, it gets to /src/assets/images it's there

that's literally the problem. lib/assets/images should exist and flat.png should be copied in there.

flat.png it's there

molecula451 commented 11 months ago

there is no such thing as lib/assets/images but

about flat.png, it gets to /src/assets/images it's there

that's literally the problem. lib/assets/images should exist and flat.png should be copied in there.

also I see you're on Node on Windows, it might be interesting to reproduce this there with a new issue

I'm on MacOS. This is a problem we had before so I know it's reproducible.

In your case i see You are not Even getting a src folder. Try a Ubuntu docker

whilefoo commented 11 months ago

In your case i see You are not Even getting a src folder. Try a Ubuntu docker

What do you mean? I have src folder and I'm running the bot after I create lib/assets/images/flat.png just fine.

whilefoo commented 11 months ago

flat.png it's there

flat.png is not in lib/assets/images

molecula451 commented 11 months ago

In your case i see You are not Even getting a src folder. Try a Ubuntu docker

What do you mean? I have src folder and I'm running the bot after I create lib/assets/images/flat.png just fine.

You got lib/src/assets/images?

molecula451 commented 11 months ago

flat.png it's there

flat.png is not in lib/assets/images

It is mate can't reproduce this one. I reproduce the original for the PR

whilefoo commented 11 months ago

In your case i see You are not Even getting a src folder. Try a Ubuntu docker

What do you mean? I have src folder and I'm running the bot after I create lib/assets/images/flat.png just fine.

You got lib/src/assets/images?

After I run yarn build, lib/assets gets created but lib/assets/images folder doesn't.

0x4007 commented 11 months ago

that's literally the problem. lib/assets/images should exist and flat.png should be copied in there.

We can remove this entirely its for a partially implemented feature for weekly updates on Telegram. Maybe this one #108.

If I recall correctly, we used to generate a graphic with all the stats from the GitHub to post weekly on Telegram. It was never a stable feature so it might be worthwhile to totally wipe the code and bring it back in the future (but on the ubiquibot-telegram repo perhaps)

molecula451 commented 11 months ago

The thing is to me is aother issue because Whilefool has it but cannot reproduce but i can reproduce the original to the PR

ubiquity / ubiquibot