ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 59 forks source link

Settlements Table Schema #808

Closed 0x4007 closed 6 months ago

0x4007 commented 11 months ago

Settlements

Represents the overarching record of a financial activity. Each entry can have references to either a credit or a debit.

Field Type Description
id int8 Unique identifier for the settlement.
created timestamptz Timestamp when the settlement was created.
updated timestamptz Timestamp when the settlement was last updated.
user_id int8 GitHub id of the user penalized. 139262667
org_id int8 GitHub id of the organization. 76412717
repo_id int8 GitHub id of the repository where the issue is located. 534616569
issue_id int8 GitHub id of the issue related to the penalty. 1868425596
credit_id int8 Foreign key to the Credits table.
debit_id int8 Foreign key to the Debits table.
GaryThisSidee commented 11 months ago

/start

ubiquibot[bot] commented 11 months ago

Deadline Mon, 25 Sep 2023 12:44:25 UTC
Registered Wallet 0x2bBc6a8314044d70684C74CfA0E117eb75E3708c
Tips:
seprintour commented 11 months ago

@GaryThisSidee This depends on the Credit and Debit table, you'd have to set up a constraint and make sure it can only have a credit id or a debit id (not both)

  • Set up foreign key constraints for creditId and debitId in the Settlements table.
  • Application logic should prevent a Settlements entry from having both a creditId and a debitId.

from the description: https://github.com/ubiquity/ubiquibot/issues/787#issue-1904968117

Credit and Debit have to merged and then you need to add a function to create a table in permit, credit and settlement tables for every permit generated

seprintour commented 11 months ago

So you'd have to wait for #810 and #811, and maybe #819 to be merged in for this to work

GaryThisSidee commented 11 months ago

@GaryThisSidee This depends on the Credit and Debit table, you'd have to set up a constraint and make sure it can only have a credit id or a debit id (not both)

  • Set up foreign key constraints for creditId and debitId in the Settlements table.
  • Application logic should prevent a Settlements entry from having both a creditId and a debitId.

from the description: #787 (comment)

Credit and Debit have to merged and then you need to add a function to create a table in permit, credit and settlement tables for every permit generated

ohh i see

GaryThisSidee commented 11 months ago

@seprintour looks like u already working on #811 should i do the #810 ?

seprintour commented 11 months ago

@seprintour looks like u already working on #811 should i do the #810 ?

Yea, you can start working on it.. It also depends on #811 though..

There's a field for permitId

ubiquibot[bot] commented 11 months ago

Do you have any updates @GaryThisSidee? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Mon Sep 25 2023 12:17:13 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 10 months ago

@GaryThisSidee - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Mon Sep 25 2023 12:17:13 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 6 months ago
+ Evaluating results. Please wait...
ubiquibot[bot] commented 6 months ago

@pavlovcik the deadline is at 2024-02-17T12:34:34.314Z

ubiquibot[bot] commented 6 months ago
+ Evaluating results. Please wait...
ubiquibot[bot] commented 6 months ago

[ 346.2 WXDAI ]

@pavlovcik
Contributions Overview
ViewContributionCountReward
IssueSpecification161.2
IssueTask1.00112.5
ReviewComment14115
ReviewComment1457.5
Conversation Incentives
CommentFormattingRelevanceReward
## **Settlements** Represents the overarching record of a fin...
61.2
h2:
  count: 1
  score: "1"
  words: 3
code:
  count: 13
  score: "13"
  words: 13
td:
  count: 27
  score: "27"
  words: 104
161.2
This should have merged this in weeks ago. The number of outstan...
18.2-18.2
@0xcodercrane In this case you should consider just regenerating...
7.6-7.6
Don't think it matters the order regarding conflicts but technic...
3.8-3.8
My mistake for not clarifying but the requirements inherit from ...
4-4
Will need to e2e test and merge...
1.4-1.4
Review comments at https://github.com/ubiquity/ubiquibot/pull/84...
2-2
There are many dimensions of your proposal to consider so it's h...
16.8-16.8
This should work on personal accounts (not just organizations) a...
4.8-4.8
Notes to self on incentive calculation architecture: - work bac...
9.6
li:
  count: 2
  score: "4"
  words: 21
-9.6
I think next week. It feels really close to being done but I'm a...
5.6-5.6
@wannacfuture its better that you branch from here instead of pu...
3.8-3.8
> I'm trying to use the new version with workflow dispatcher and...
17
code:
  count: 1
  score: "2"
  words: 26
-17
You guys should make sure you're using the same version of Node....
18.4-18.4
@gitcoindev maybe you can help fix the knip CI here...
2-2
This should have merged this in weeks ago. The number of outstan...
9.1-9.1
@0xcodercrane In this case you should consider just regenerating...
3.8-3.8
Don't think it matters the order regarding conflicts but technic...
1.9-1.9
My mistake for not clarifying but the requirements inherit from ...
2-2
Will need to e2e test and merge...
0.7-0.7
Review comments at https://github.com/ubiquity/ubiquibot/pull/84...
1-1
There are many dimensions of your proposal to consider so it's h...
8.4-8.4
This should work on personal accounts (not just organizations) a...
2.4-2.4
Notes to self on incentive calculation architecture: - work bac...
4.8
li:
  count: 2
  score: "2"
  words: 21
-4.8
I think next week. It feels really close to being done but I'm a...
2.8-2.8
@wannacfuture its better that you branch from here instead of pu...
1.9-1.9
> I'm trying to use the new version with workflow dispatcher and...
8.5
code:
  count: 1
  score: "1"
  words: 26
-8.5
You guys should make sure you're using the same version of Node....
9.2-9.2
@gitcoindev maybe you can help fix the knip CI here...
1-1

[ 17.15 WXDAI ]

@seprintour
Contributions Overview
ViewContributionCountReward
IssueComment314.05
ReviewComment23.1
Conversation Incentives
CommentFormattingRelevanceReward
@GaryThisSidee This depends on the Credit and Debit table, you'd...
10.05
li:
  count: 2
  score: "0.5"
  words: 40
code:
  count: 9
  score: "2.25"
  words: 9
0.84510.05
So you'd have to wait for #810 and #811, and maybe #819 to be me...
2.10.732.1
> @seprintour looks like u already working on #811 should i do ...
1.90.4451.9
Check comment on issue @GaryThisSidee ...
0.5-0.5
@whilefoo this is not my PR, it's incomplete anyway and it's sup...
2.6-2.6

[ 0 WXDAI ]

@BeanieMen
Contributions Overview
ViewContributionCountReward
ReviewComment10
Conversation Incentives
CommentFormattingRelevanceReward
🎉...
---

[ 52.6 WXDAI ]

@gitcoindev
Contributions Overview
ViewContributionCountReward
ReviewComment752.6
Conversation Incentives
CommentFormattingRelevanceReward
> There also seems to be an issue with ubiquibot-logger > > `...
9.1
code:
  count: 4
  score: "4"
  words: 4
-9.1
> > Hi @whilefoo , the `ubiquibot-logger` is an ESM module https...
7.3
code:
  count: 5
  score: "5"
  words: 7
-7.3
> > > Hi @whilefoo , the `ubiquibot-logger` is an ESM module htt...
14.9
code:
  count: 7
  score: "7"
  words: 10
-14.9
hi @whilefoo I will give this priority and try to fix till Monda...
1.4-1.4
@whilefoo I am on v0.3.4 already, so far no luck but closer and ...
5.2-5.2
hi @whilefoo could you please check ubiquibot-logger v0.3.5 ? I...
8.9
code:
  count: 1
  score: "1"
  words: 6
-8.9
Btw, about @pavlovcik 's last comment, I agree that we should sy...
5.8-5.8

[ 1.6 WXDAI ]

@0xcodercrane
Contributions Overview
ViewContributionCountReward
ReviewComment11.6
Conversation Incentives
CommentFormattingRelevanceReward
should I merge https://github.com/ubiquity/ubiquibot/pull/643 in...
1.6-1.6

[ 0.6 WXDAI ]

@wannacfuture
Contributions Overview
ViewContributionCountReward
ReviewComment10.6
Conversation Incentives
CommentFormattingRelevanceReward
should I resolve the conflicts? @pavlovcik ...
0.6-0.6

[ 139.7 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
ReviewComment3139.7
Conversation Incentives
CommentFormattingRelevanceReward
@pavlovcik There is the supabase [diff tool](https://supabas...
42.1
a:
  count: 4
  score: "4"
  words: 7
li:
  count: 7
  score: "7"
  words: 110
code:
  count: 10
  score: "10"
  words: 11
-42.1
@pavlovcik Regarding the `locations` and metadata. This i...
96
h2:
  count: 2
  score: "2"
  words: 11
h3:
  count: 4
  score: "4"
  words: 4
a:
  count: 2
  score: "2"
  words: 3
li:
  count: 10
  score: "10"
  words: 170
code:
  count: 21
  score: "21"
  words: 67
td:
  count: 16
  score: "16"
  words: 57
-96
> Alternatively we do the two API calls but there's a good chanc...
1.6-1.6

[ 25.7 WXDAI ]

@whilefoo
Contributions Overview
ViewContributionCountReward
ReviewComment725.7
Conversation Incentives
CommentFormattingRelevanceReward
@seprintour ...
0.1-0.1
oh sorry!...
0.2-0.2
I'm trying to use the new version with workflow dispatcher and I...
6.8
code:
  count: 1
  score: "1"
  words: 26
-6.8
There also seems to be an issue with ubiquibot-logger ``` co...
7.9
code:
  count: 1
  score: "1"
  words: 0
-7.9
> Hi @whilefoo , the `ubiquibot-logger` is an ESM module https:/...
8.9
code:
  count: 5
  score: "5"
  words: 7
-8.9
> Following the article https://dev.to/tigawanna/building-and-pu...
1.2-1.2
@gitcoindev it's working now, thanks!...
0.6-0.6

[ 3.7 WXDAI ]

@EtherealGlow
Contributions Overview
ViewContributionCountReward
ReviewComment53.7
Conversation Incentives
CommentFormattingRelevanceReward
I pray for the refactor to be done quickly 🙏...
0.9-0.9
Do you guys have any estimate on when the refactor will be done ...
1.3-1.3
Any new estimate for how much time is left?...
0.9-0.9
🙏...
---
When will the refactor be done 😭...
0.6-0.6