ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
17 stars 59 forks source link

chore: create permit table and move data #817

Open seprintour opened 11 months ago

seprintour commented 11 months ago

Resolves #811

Quality Assurance:

Screenshot 2023-09-23 at 7 27 19 PM

Screenshot 2023-09-23 at 7 25 21 PM

More QA: https://github.com/Seprintour-Test/test/issues/41#issuecomment-1732585892 Screenshot 2023-09-24 at 3 30 56 PM

I also changed the datatype from char to varchar to fix this error https://github.com/Seprintour-Test/test/issues/41#issuecomment-1732579005 @pavlovcik

netlify[bot] commented 11 months ago

Deploy Preview for ubiquibot-staging ready!

Name Link
Latest commit 3d4659038508ce4ff3ded9dae38c9f1e088564a2
Latest deploy log https://app.netlify.com/sites/ubiquibot-staging/deploys/6523e49b5607da0008773cf4
Deploy Preview https://deploy-preview-817--ubiquibot-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

seprintour commented 11 months ago

@pavlovcik PR attached

0x4007 commented 11 months ago

The bot is expected to be stable after these changes are implemented which implies that all of the functions that interact with the database should also be refactored to accomodate this new architecture.

From #787

Shouldn't you refactor functions that interact with these tables?

seprintour commented 11 months ago

From #787

Shouldn't you refactor functions that interact with these tables?

Yea, I would do that now..

seprintour commented 11 months ago

Shouldn't you refactor functions that interact with these tables?

check it out now, i ran into some more issues and fixed.. check description

seprintour commented 11 months ago

Code looks good just have some rename requests

Fixed issues

seprintour commented 11 months ago

Ping @pavlovcik @whilefoo

seprintour commented 10 months ago

Even if we ignore the bug with char(x), people are mostly recommending to use text because char and varchar have some limits

@pavlovcik what's your thought on this, and did the schema change again?

I'm seeing some changes on the parent issue

0x4007 commented 10 months ago

To be honest I spent a significant amount of time trying to completely redo the database and functions that interact with it. I seem to have underestimated the amount of work involved but it forces me to become intimately familiar with all of these technologies and concepts within our bot.

It might be more productive to focus efforts elsewhere this week as I continue my research

seprintour commented 10 months ago

@0xcodercrane @whilefoo i made it a text with a length constraint like agreed

whilefoo commented 10 months ago

@seprintour can you make new QA issue to make sure everything is working?

seprintour commented 10 months ago

@seprintour can you make new QA issue to make sure everything is working?

Sure