Open seprintour opened 11 months ago
Name | Link |
---|---|
Latest commit | 3d4659038508ce4ff3ded9dae38c9f1e088564a2 |
Latest deploy log | https://app.netlify.com/sites/ubiquibot-staging/deploys/6523e49b5607da0008773cf4 |
Deploy Preview | https://deploy-preview-817--ubiquibot-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@pavlovcik PR attached
The bot is expected to be stable after these changes are implemented which implies that all of the functions that interact with the database should also be refactored to accomodate this new architecture.
From #787
Shouldn't you refactor functions that interact with these tables?
From #787
Shouldn't you refactor functions that interact with these tables?
Yea, I would do that now..
Shouldn't you refactor functions that interact with these tables?
check it out now, i ran into some more issues and fixed.. check description
Code looks good just have some rename requests
Fixed issues
Ping @pavlovcik @whilefoo
Even if we ignore the bug with char(x), people are mostly recommending to use text because char and varchar have some limits
@pavlovcik what's your thought on this, and did the schema change again?
I'm seeing some changes on the parent issue
To be honest I spent a significant amount of time trying to completely redo the database and functions that interact with it. I seem to have underestimated the amount of work involved but it forces me to become intimately familiar with all of these technologies and concepts within our bot.
It might be more productive to focus efforts elsewhere this week as I continue my research
@0xcodercrane @whilefoo i made it a text
with a length constraint like agreed
@seprintour can you make new QA issue to make sure everything is working?
@seprintour can you make new QA issue to make sure everything is working?
Sure
Resolves #811
Quality Assurance:
More QA: https://github.com/Seprintour-Test/test/issues/41#issuecomment-1732585892![Screenshot 2023-09-24 at 3 30 56 PM](https://github.com/ubiquity/ubiquibot/assets/51956013/35f639c1-e085-4fe2-abe0-8f4f75078445)
I also changed the datatype from
char
tovarchar
to fix this error https://github.com/Seprintour-Test/test/issues/41#issuecomment-1732579005 @pavlovcik