search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
16 stars 59 forks source link

Incentives not adding Assignee + Creator rewards on permit amount #834

Open seprintour opened 9 months ago

seprintour commented 9 months ago

Permit comment says 95.1 WXDAI but permit amount was 37.5 WXDAI

Well it combined your rewards for identifying the issue and fixing it. It just gave you a lot of rewards for issue creation, which we will eventually limit to the bounty price. I think it looks fine.

It added it in the permit comment but when i try to claim, it does not add the creator amount

I traced it down to this line: https://github.com/ubiquity/ubiquibot/blob/f41c03691d5849e546db8bfb62b907122294a820/src/handlers/payout/action.ts#L415

It's supposed to be priceInEth not assigneeReward.reward[0].priceInEth

Originally posted by @seprintour in https://github.com/ubiquity/ubiquibot-telegram/issues/29#issuecomment-1732534328

devpanther commented 9 months ago

This is outdated now, already fixed in #375