Open 0x4007 opened 1 year ago
@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like
export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }
this to resolve that I hope this is the issue you were addressing to.
/start
Deadline | Tue, 26 Sep 2023 16:52:45 UTC |
Registered Wallet | Please set your wallet address to use `/wallet 0x0000...0000` |
/wallet 0x0000...0000
if you want to update your registered payment wallet address @user.Do you have any updates @abhinandanmishra1? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Tue Sep 26 2023 15:52:38 GMT+0000 (Coordinated Universal Time)
@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like
export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }
this to resolve that I hope this is the issue you were addressing to.
It is not clear to me why you need a getter function to use the string. An export/import would do the job just the same
@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like
export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }
this to resolve that I hope this is the issue you were addressing to.
It is not clear to me why you need a getter function to use the string. An export/import would do the job just the same
I did not know that if that is the case then it's even better
/stop
You have been unassigned from the bounty @abhinandanmishra1
/start
Deadline | Sun, 01 Oct 2023 14:19:06 UTC |
Registered Wallet | 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025 |
/wallet 0x0000...0000
if you want to update your registered payment wallet address @user.Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Sun Oct 01 2023 13:19:02 GMT+0000 (Coordinated Universal Time)
Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment
/stop
Last activity time: Sun Oct 01 2023 13:19:02 GMT+0000 (Coordinated Universal Time)
yes I will open a PR by tommorrow. I was busy with college
@pavlovcik the file mentioned in the issue description does not exist anymore I'll try to find some other file where this is happening is you are aware of any such instances please let me know
/stop
You have been unassigned from the bounty @Sadaf-A
since, whilefoo is back I will complete the PRs being reviewed by him then get back to this
/start
Deadline | Sun, 15 Oct 2023 12:14:59 UTC |
Registered Wallet | 0xAe5D1F192013db889b1e2115A370aB133f359765 |
/wallet 0x0000...0000
if you want to update your registered payment wallet address @user.Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Tue Oct 17 2023 08:20:33 GMT+0000 (Coordinated Universal Time)
awaiting response to latest comment on pr
Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Sat Oct 21 2023 23:28:38 GMT+0000 (Coordinated Universal Time)
/stop
Skipping /stop
because it is disabled on this repo
Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Wed Oct 25 2023 23:46:28 GMT+0000 (Coordinated Universal Time)
Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop
Last activity time: Wed Nov 01 2023 14:32:13 GMT+0000 (Coordinated Universal Time)
_Originally posted by @pavlovcik in https://github.com/ubiquity/ubiquibot/pull/640#discussion_r1303891004_