search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
16 stars 59 forks source link

Tests: Share Strings #837

Open 0x4007 opened 9 months ago

0x4007 commented 9 months ago 
          Do you think it's feasible that we export and use the exact same strings from the code base?

_Originally posted by @pavlovcik in https://github.com/ubiquity/ubiquibot/pull/640#discussion_r1303891004_

Sadaf-A commented 9 months ago

@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like 

export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }

this to resolve that I hope this is the issue you were addressing to.

abhinandanmishra1 commented 9 months ago

/start

ubiquibot[bot] commented 9 months ago

Deadline Tue, 26 Sep 2023 16:52:45 UTC
Registered Wallet Please set your wallet address to use `/wallet 0x0000...0000`
Tips:
ubiquibot[bot] commented 9 months ago

Do you have any updates @abhinandanmishra1? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Tue Sep 26 2023 15:52:38 GMT+0000 (Coordinated Universal Time)

0x4007 commented 9 months ago

@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like 

export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }

this to resolve that I hope this is the issue you were addressing to.

It is not clear to me why you need a getter function to use the string. An export/import would do the job just the same

Sadaf-A commented 9 months ago

@pavlovcik I do see an issue with that when we want to change something later it will have to be changed everywhere. Why not store string constants in a single file and export the string from there instead of copying the whole string.However, interpolation may not work when we export string it may be treated as a plain string.We can use something like 

export function myString(varValue: string): string { return `Value of var is: ${varValue}`; }

this to resolve that I hope this is the issue you were addressing to.

It is not clear to me why you need a getter function to use the string. An export/import would do the job just the same

I did not know that if that is the case then it's even better

abhinandanmishra1 commented 9 months ago

/stop

ubiquibot[bot] commented 9 months ago

You have been unassigned from the bounty @abhinandanmishra1

Sadaf-A commented 9 months ago

/start

ubiquibot[bot] commented 9 months ago

Deadline Sun, 01 Oct 2023 14:19:06 UTC
Registered Wallet 0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tips:

ubiquibot[bot] commented 9 months ago

Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sun Oct 01 2023 13:19:02 GMT+0000 (Coordinated Universal Time)

Sadaf-A commented 9 months ago

Do you have any updates @Sadaf-A? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sun Oct 01 2023 13:19:02 GMT+0000 (Coordinated Universal Time)

yes I will open a PR by tommorrow. I was busy with college

Sadaf-A commented 9 months ago

@pavlovcik the file mentioned in the issue description does not exist anymore I'll try to find some other file where this is happening is you are aware of any such instances please let me know

Sadaf-A commented 9 months ago

/stop

ubiquibot[bot] commented 9 months ago

You have been unassigned from the bounty @Sadaf-A

Sadaf-A commented 9 months ago

since, whilefoo is back I will complete the PRs being reviewed by him then get back to this

Keyrxng commented 9 months ago

/start

ubiquibot[bot] commented 9 months ago

Deadline Sun, 15 Oct 2023 12:14:59 UTC
Registered Wallet 0xAe5D1F192013db889b1e2115A370aB133f359765

Tips:

ubiquibot[bot] commented 8 months ago

Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Tue Oct 17 2023 08:20:33 GMT+0000 (Coordinated Universal Time)

Keyrxng commented 8 months ago

awaiting response to latest comment on pr

ubiquibot[bot] commented 8 months ago

Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Sat Oct 21 2023 23:28:38 GMT+0000 (Coordinated Universal Time)

Keyrxng commented 8 months ago

/stop

ubiquibot[bot] commented 8 months ago

Skipping /stop because it is disabled on this repo

ubiquibot[bot] commented 8 months ago

Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Oct 25 2023 23:46:28 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 8 months ago

Do you have any updates @Keyrxng? If you would like to release the bounty back to the DevPool, please comment /stop Last activity time: Wed Nov 01 2023 14:32:13 GMT+0000 (Coordinated Universal Time)