feat: add comment-incentive command

BeanieMen commented 9 months ago

Resolves #780

Quality Assurance:

netlify[bot] commented 9 months ago

Deploy Preview for ubiquibot-staging ready!

Name	Link
Latest commit	44c5ccb9c02a41da9961e48d7864ea1203f80bd9
Latest deploy log	https://app.netlify.com/sites/ubiquibot-staging/deploys/652d2986ee395a0008d88c27
Deploy Preview	https://deploy-preview-840--ubiquibot-staging.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

0x4007 commented 9 months ago

Needs proof that it works before review

BeanieMen commented 9 months ago

@pavlovcik https://github.com/ubiquity/ubiquibot/pull/735#issuecomment-1734785730

BeanieMen commented 9 months ago

can we rename comment-incentives to incentivize because somehow it is not working with comment-incentive @whilefoo

BeanieMen commented 9 months ago

are comment incentives not generated for issue creator?

whilefoo commented 9 months ago

@me505

BeanieMen commented 9 months ago

@pavlovcik can /incentivize work instead of /comment-incentive

BeanieMen commented 9 months ago

@pavlovcik can /incentivize work instead of /comment-incentive

@pavlovcik

BeanieMen commented 9 months ago

@whilefoo the command is now working and so is the function https://github.com/me505/ubiquibot/issues/14

BeanieMen commented 9 months ago

can you just help me set up comment incentives to test if this works or not

whilefoo commented 9 months ago

can you just help me set up comment incentives to test if this works or not

what's the issue?

BeanieMen commented 9 months ago

the problem is that incentive rewards might not be getting calculated

BeanieMen commented 9 months ago

i tried explicitly setting the rewardValue.sum to new Decimal(1) but to no avail

BeanieMen commented 9 months ago

@whilefoo is there anything I need to setup for comment incentives

whilefoo commented 9 months ago

@me505 I think it's because creator is excluded from conversation rewards https://github.com/ubiquity/ubiquibot/blob/3ad77e54a0202e442bdc7e2973326e8a7a32b74a/src/handlers/payout/action.ts#L365

BeanieMen commented 9 months ago

i literally have no idea why this isnt working

BeanieMen commented 9 months ago

https://github.com/me505/ubiquibot/issues/28

BeanieMen commented 9 months ago

i am running the development branch which isn't changed in any way

whilefoo commented 9 months ago

you should comment with an account that is not creator or assignee

BeanieMen commented 8 months ago

https://github.com/me505/ubiquibot/issues/31 https://github.com/me505/ubiquibot/issues/30

BeanieMen commented 8 months ago

@whilefoo its working

BeanieMen commented 8 months ago

@whilefoo can you review this

BeanieMen commented 5 months ago

@pavlovcik am I able to work on this now?

ubiquity / ubiquibot