search

ubiquity / ubiquibot

Putting the 'A' in 'DAO'
https://github.com/marketplace/ubiquibot
MIT License
16 stars 59 forks source link

Refactor logging into a separate NPM module #899

Closed gitcoindev closed 7 months ago

gitcoindev commented 7 months ago

As requested and discussed with @pavlovcik .

0x4007 commented 7 months ago

How's this coming along?

gitcoindev commented 7 months ago

I will try to push a pull request today.

gitcoindev commented 7 months ago

Still testing, has to fix one export but looks almost good now.

Related changes needed to switch to NPM logging module in refactor/general branch: https://github.com/pavlovcik/ubiquibot/pull/60

gitcoindev commented 7 months ago

Pull request ready for the review.

ubiquibot[bot] commented 7 months ago 
! action returned an unexpected value
ubiquibot[bot] commented 7 months ago 
! No price label has been set. Skipping permit generation.
0x4007 commented 7 months ago 
! action returned an unexpected value
{
  "logReturn": null,
  "handlerType": {
    "type": "wildcard",
    "actions": [
      null
    ]
  },
  "activeHandler": "checkTasksToUnassign",
  "caller": "renderCatchAll",
  "revision": "07ce845"
}

As you can see we are close to go shipping. Just debugging some small last issues still.

gitcoindev commented 7 months ago 
! action returned an unexpected value
{
  "logReturn": null,
  "handlerType": {
    "type": "wildcard",
    "actions": [
      null
    ]
  },
  "activeHandler": "checkTasksToUnassign",
  "caller": "renderCatchAll",
  "revision": "07ce845"
}

As you can see we are close to go shipping. Just debugging some small last issues still.

I am quite sure we will make it.