search

ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
34 stars 91 forks source link

Update CI to Node 16 #311

Closed 0x4007 closed 1 year ago

0x4007 commented 2 years ago

receive-pr-and-deploy Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/github-script, actions/checkout

0xcodercrane commented 2 years ago

receive-pr-and-deploy Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/github-script, actions/checkout

I think we should upgrade to 18.x because 16.x went into maintenance. https://github.com/nodejs/release#release-schedule

0x4007 commented 1 year ago

build-and-test Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-node@v2, actions/upload-artifact@v2

zgorizzo69 commented 1 year ago

I found the problem will take care of that

zgorizzo69 commented 1 year ago

done https://github.com/ubiquity/ubiquity-dollar/actions/runs/3679952590 https://github.com/ubiquity/ubiquity-dollar/actions/runs/3679951103 there is only a warning for new latest ubuntu version that will be v22 and we should be fine as it impacts ruby, php and python version.

zgorizzo69 commented 1 year ago

on a precautionary basis I tried it with ubuntu 22.04 and it works great :+1: https://github.com/ubiquity/ubiquity-dollar/actions/runs/3680087591 https://github.com/ubiquity/ubiquity-dollar/actions/runs/3680087453

0xcodercrane commented 1 year ago

Lets just replace it with ubuntu-22.04 and merge your PR. by the way, replace should be happening in both yml files in .github/workflows

zgorizzo69 commented 1 year ago

Lets just replace it with ubuntu-22.04 and merge your PR. by the way, replace should be happening in both yml files in .github/workflows

done !

sergfeldman commented 1 year ago

@zgorizzo69 https://etherscan.io/tx/0x36a4c9a4cd8debc539e2bf2a229149612fd284d6861374c56dff40172454db9e

0x4007 commented 1 year ago

I just merged zgo's #311