Bot Deploys Comment Should Include Commit Hashes

0x4007 commented 1 year ago

I was trying to understand which commit corresponds to which deployment but the commit hashes don't seem to match based on what I see inside of the rendered dApp.

The deployment links from the bot also do not include the commit hashes.

Verifying by timestamp seems unnecessarily imprecise.

Deployment: Mon May 29 2023 10:18:51 (UTC) Deployment: Mon May 29 2023 11:48:24 (UTC) Deployment: Mon May 29 2023 13:27:19 (UTC) Deployment: Mon May 29 2023 13:38:49 (UTC) Deployment: Mon May 29 2023 13:42:03 (UTC)

Originally posted by @ubiquibot[bot] in https://github.com/ubiquity/ubiquity-dollar/issues/661#issuecomment-1566917449

PhantomCracker commented 1 year ago

/start

ubiquibot[bot] commented 1 year ago



  
    
    
  
  
    Deadline
    Tue, 29 Aug 2023 08:34:42 UTC
  
  
    Registered Wallet
    0x4007CE2083c7F3E18097aeB3A39bb8eC149a341d

Tips:

Use /wallet 0x0000...0000 if you want to update your registered payment wallet address @user.
Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the bounty.

0x4007 commented 1 year ago

Due to delays on our end I will make an exception for you @PhantomCracker. Technically speaking even if you are not assigned you are free to open a pull request. However you may be frontran by somebody else who gets assigned.

ubiquibot[bot] commented 1 year ago

@PhantomCracker The time limit for this bounty is on Sun, 04 Jun 2023 12:42:26 GMT

ubiquibot[bot] commented 1 year ago

[ CLAIM 50 WXDAI ]

0xCAC0A8cF...29AF40A6

ubiquibot[bot] commented 1 year ago

Error: Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="symbol()", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)

ubiquibot[bot] commented 1 year ago

@PhantomCracker - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Sat Jun 03 2023 09:06:01 GMT+0000 (Coordinated Universal Time)

0x4007 commented 1 year ago

This wasn't implemented correctly because the list doesnt grow with new deployments.

https://github.com/ubiquity/ubiquity-dollar/blob/7e9c8b5e2481a89ebe161458fe687f7e21382fc8/utils/print-deployments-logs.js#L30C82-L30C82

This line is suspicious because its looking for the old "Deployment" string which has been replaced by the hash for example.

0x4007 commented 1 year ago

@rndquu I understand that we are using this logic in our organization wide continuous deploys. Would you mind prioritizing this and taking this over to make sure its done correctly?

PhantomCracker commented 1 year ago

Hm... I see that the issue isn't made by my code; still, I can do this after I finish with 2 more bounties that I am working on it right now.

ubiquibot[bot] commented 1 year ago

@pavlovcik - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Thu Aug 10 2023 00:33:16 GMT+0000 (Coordinated Universal Time)

ubiquibot[bot] commented 1 year ago

@rndquu The time limit for this bounty is on Tue, 29 Aug 2023 08:49:51 UTC

ubiquibot[bot] commented 1 year ago

@rndquu - Releasing the bounty back to dev pool because the allocated duration already ended! Last activity time: Wed May 31 2023 02:03:08 GMT+0000 (Coordinated Universal Time)

0x4007 commented 1 year ago

I believe you fixed this @rndquu so I was trying to assign and close to you.

rndquu commented 1 year ago

I believe you fixed this @rndquu so I was trying to assign and close to you.

Yes, printing commit hashes is already implemented in a shared cloudflare deploy workflow

ubiquibot[bot] commented 1 year ago

@rndquu The time limit for this bounty is on Tue, 29 Aug 2023 09:19:48 UTC

ubiquibot[bot] commented 1 year ago

Error: Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="symbol()", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)

ubiquibot[bot] commented 1 year ago

Task Creator Reward

pavlovcik: [ CLAIM 30 WXDAI ]

ubiquibot[bot] commented 1 year ago

Error: Error: call revert exception [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (method="symbol()", data="0x", errorArgs=null, errorName=null, errorSignature=null, reason=null, code=CALL_EXCEPTION, version=abi/5.7.0)

Its unusual that only the assignee reward is crashing.

0x4007 commented 1 year ago

/query @rndquu

ubiquibot[bot] commented 1 year ago

@rndquu's wallet address is 0x336C033842FA316d470e820c81b742e62A0765DC and multiplier is 1

ubiquity / ubiquity-dollar