ci: using foundry from 2 Oct 2023

[rndquu]

This PR sets foundry toolchain action for the version dated on 28 Sep 2023.

This is the closest release with the vm.parseJsonKeys feature (which is needed for this issue).

Chances are that this release will be removed in the future (because it is pretty much a fresh one and foundry tends to delete releases from time to time) but I haven't found any other ones with the vm.parseJsonKeys feature.

[ubiquibot[bot]]

• 34cc28e
• 34cc28e
• 34cc28e
• 34cc28e
• 9ac6770
• a9dac4f

[molecula451]

so we need it for #616 good catch @rndquu, but we shouldn't rely on fresh release, they act fast, it will broke the CI

[rndquu]

so we need it for #616 good catch @rndquu, but we shouldn't rely on fresh release, they act fast, it will broke the CI

I don't have other ideas except simply using the latest nightly build which also might break the CI

[molecula451]

and also if it breaks, then we change the CI, it will break the implementantion, what about we wait for a proper release and postpone #616

[gitcoindev]

Yes, in such cases staging area is helpful. Foundry has been always 'nightly' so far but some nightlies are marked as pre-release.

I had a quick look and since the previous used version changes can be analyzed here

https://github.com/foundry-rs/foundry/compare/nightly-d369d2486f85576eec4ca41d277391dfdae21ba7...nightly-96ab9131e6735df35aca0249968c7d339590de20

The version selected by @rndquu was fortunately selected / pinned recently as a pre-release https://github.com/foundry-rs/foundry/tags vs https://github.com/foundry-rs/foundry/releases (see the pre-release label on 28th September) so it might have a chance for survival.

[molecula451]

judging by the #803 i will consider #616 as breaking even tho it's labeled as a small task, we could give it a try but when we have to deal with reverts PR (in extreme cases) because rndqnuu changes a lot of things at #803

[rndquu]

https://github.com/foundry-rs/foundry/releases/tag/nightly-96ab9131e6735df35aca0249968c7d339590de20

[molecula451]

this release https://github.com/foundry-rs/foundry/releases/tag/nightly-96ab9131e6735df35aca0249968c7d339590de20 mentioned by rndqnuu in this PR was just removed

[molecula451]

lol notice at the same time

[molecula451]

but yeah i mean, i don't think you want to stale #616 and judging by when we found "stable" commit it was months, so i think it will take a few months to have a stable with the new implementation vm.parseJsonKey

[rndquu]

but yeah i mean, i don't think you want to stale #616 and judging by when we found "stable" commit it was months, so i think it will take a few months to have a stable with the new implementation vm.parseJsonKey

I'm refactoring the deployment script and this issue is a part of this refactoring

[rndquu]

Ok, right now foundry release from 30 Sep is set, let's wait for a couple of days. If it is not removed then I will merge the current PR because I really need the vm.parseJsonKeys feature.

[molecula451]

we can deal with fixes if they come by

[gitcoindev]

Interestingly I noticed that previously they kept always pre-release from 2nd day of a month. If this is still the case the one from October 2nd will stay. Let's see.

[gitcoindev]

2nd Oct 2023 release seems to have survived till now :tada: