ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
32 stars 88 forks source link

`dApp`: UI fixes #815

Closed molecula451 closed 2 weeks ago

molecula451 commented 11 months ago

What should be done:

  1. Fix "network error" when credits page is opened (context)
  2. There is the uniswap widget in the credits page. Not sure if it is used somehow. If it is used then we should make it responsive else we're free to remove it.
  3. Check the frontend app for unused components which should be removed
  4. Fix errors on network switches. There should not be any errors when user switches between mainnet, testnet or anvil.
  5. Fix wallet connect errors. When you authorize via wallet connect (ex: metamask) there are errors in the console like Error: missing revert data in call exception; Transaction reverted without a reason string or invalid key. We should fix all auth errors.
  6. Update Prettier
rndquu commented 11 months ago

Could you elaborate on which UI packages should be updated and why?

molecula451 commented 11 months ago

smart-order-router uniswap for e.g, to fix the Network Error issue

molecula451 commented 11 months ago

but if we're going to purge the widget we will probably not need it

molecula451 commented 11 months ago

@rndquu wallet connect should be fixed why do we keep getting error key on production deployment dapp? The secret k Is not being readen?

rndquu commented 11 months ago

@rndquu wallet connect should be fixed why do we keep getting error key on production deployment dapp? The secret k Is not being readen?

Updated description

molecula451 commented 11 months ago

@rndquu wallet connect should be fixed why do we keep getting error key on production deployment dapp? The secret k Is not being readen?

Updated description

nice but im referring to the error that you pass a key from walletconnect.org at .env

https://github.com/molecula451/ubiquity-dollar/blob/97989f176ebcbf0e726d3d5aa5029e85fc1f15d0/packages/dapp/.env.example#L3

wallet

molecula451 commented 11 months ago

if we are purging uniswap widget what's the point of refactoring the credit-redeem.tsx it's connected to it, are we therefore getting rigged of this credit redeem? @rndquu

molecula451 commented 11 months ago

the router seem it was used to swap back the credits to dollar and dollar to credits, and along with the tokens at https://github.com/ubiquity/ubiquity-dollar/blob/97989f176ebcbf0e726d3d5aa5029e85fc1f15d0/packages/dapp/components/lib/utils.ts#L153

molecula451 commented 11 months ago

if we remove the router its one way of getting rid of Network Error issue that is for sure

https://github.com/ubiquity/ubiquity-dollar/assets/41552663/654f85fd-7506-40c9-9a96-a84f6b59fb1d

molecula451 commented 11 months ago

also we should not be refactoring ucr-redeem.tsx at #824 if the router it's going to be purge as the main use seem to be the router there

rndquu commented 11 months ago

the router seem it was used to swap back the credits to dollar and dollar to credits, and along with the tokens at

https://github.com/ubiquity/ubiquity-dollar/blob/97989f176ebcbf0e726d3d5aa5029e85fc1f15d0/packages/dapp/components/lib/utils.ts#L153

Then we're not purging the uniswap widget

molecula451 commented 11 months ago

widget relevant data https://github.com/ubiquity/ubiquity-dollar/issues/280#issuecomment-1280491634

rndquu commented 2 weeks ago

Closing in favor of https://github.com/ubiquity/uusd.ubq.fi/issues/1

ubiquity-os[bot] commented 2 weeks ago
# Issue was not closed as completed. Skipping.