search

ubiquity / ubiquity-dollar

Ubiquity Dollar (uAD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
31 stars 82 forks source link

test: verify getCreditReturnedForDollars and getCreditNftReturnedForDollars #856

Closed gitcoindev closed 6 months ago

gitcoindev commented 6 months ago

Increases CreditNftManagerFacet test coverage, part of #838 .

Resolves: #838

gitcoindev commented 6 months ago

Development branch coverage: 69.7 PR branch coverage: 70.1

molecula451 commented 6 months ago

time for a github action bots to post coverall increase comment? on PR it would be nice @gitcoindev

gitcoindev commented 6 months ago

time for a github action bots to post coverall increase comment? on PR it would be nice @gitcoindev

I also thought about it. Currently the coverage difference it is available in the GitHub action logs, and does not pollute comments. I am not sure to be honest if we really need it to add in each pull request comment thread. For pull requests that try to increase coverage it is a good indicator, but for bug fixes and new features it may be enough if the GitHub action does not fail with decreased coverage. Perhaps @pavlovcik could you please also share your thoughts?

0x4007 commented 6 months ago

I don't see the benefit of that if we can easily see the results on CI