search

ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
34 stars 89 forks source link

chore: UbiquityPool UI Update #860

Closed rndquu closed 6 months ago

rndquu commented 9 months ago

Resolves https://github.com/ubiquity/ubiquity-dollar/issues/833

molecula451 commented 8 months ago

i think the best it's to design a new table from ground up, instead of mocking one similar to frax, what you think? @rndquu

0x4007 commented 8 months ago

Honestly I am heavily leaning towards making separate NON REACT separate pages per view. I feel like this would greatly simplify the development, at the risk of slightly non matching elements/behaviors across pages (this technically could be remedied with a shared generic stylesheet though!)

I haven't worked on this repository for a while so I haven't made any initiative towards this, but I remember that dealing with the UI in the past was incredibly unwieldily.

Anyways if you guys are more comfortable to proceed in React for now, then sure; but if I do get a chance to dive into this, there's a high chance I'm going to want to go raw (like in https://github.com/ubiquity/work.ubq.fi/)

rndquu commented 8 months ago

i think the best it's to design a new table from ground up, instead of mocking one similar to frax, what you think? @rndquu

It won't be a frax'es mock but a simple UI enough to mint/redeem Dollars

Honestly I am heavily leaning towards making separate NON REACT separate pages per view.

I like that react is widely used but don't like to choose over 100 hooks for different use cases. It was way simpler in the early days with class components.

Anyways if you guys are more comfortable to proceed in React for now, then sure; but if I do get a chance to dive into this, there's a high chance I'm going to want to go raw (like in https://github.com/ubiquity/work.ubq.fi/)

We'll finish the Ubiquity pool page with the current stack so that we could test minting and redeeming of Dollar tokens. Raw js/css will eventually bring us to a mess. If you guys have experience with some simple frontend framework then suggestions are welcome.

molecula451 commented 8 months ago

the thing is our whole frontend is make of React i think the approach you mention is good draw a simple table that shows minting/redeeming and a calculation and move on to further visual aspects, later on

0x4007 commented 8 months ago

We might be able to whip up a quick version of the UI by doing a wget -r lol

rndquu commented 6 months ago

I will open a new PR reflecting changes introduced in the audit