search

ubiquity / ubiquity-dollar

Ubiquity Dollar (UUSD) smart contracts and user interface.
https://uad.ubq.fi
Apache License 2.0
34 stars 89 forks source link

fix: deprecate incentive on dollar token #875

Closed molecula451 closed 8 months ago

molecula451 commented 8 months ago

Fixes: https://github.com/sherlock-audit/2023-12-ubiquity-judging/issues/8

molecula451 commented 8 months ago

by the way there is an incentivation mechanism in curve lp but doesn't seem relate to the token @rndquu @gitcoindev

molecula451 commented 8 months ago

all good but check #876

gitcoindev commented 8 months ago

Hi @molecula451 I also found https://github.com/ubiquity/ubiquity-dollar/blob/development/packages/contracts/src/dollar/libraries/Constants.sol#L63 I guess this and any references to it could be removed as well.

molecula451 commented 8 months ago

the thing is guess the word "incentive" was used in different sections of the code but overall with different context, say the incentive from Dollar Ubiquity differs from this facet say CreditRedemptionCalculatorFacet

@rndquu @gitcoindev

molecula451 commented 8 months ago

alright to clarify the strategy we are not merging this one until Sherlock confirmed as fixed @rndquu @gitcoindev

rndquu commented 8 months ago

alright to clarify the strategy we are not merging this one until Sherlock confirmed as fixed @rndquu @gitcoindev

I think we're free to merge